Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream #746

Open
wants to merge 71 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
71 commits
Select commit Hold shift + click to select a range
ff08570
Fix for findbug xml output
bferdinandus Jan 25, 2019
0e114c2
Add basic signature to make the findbugs xml parser happy
bferdinandus Jan 29, 2019
ed18285
Correct WhiteSpace
bferdinandus Jan 29, 2019
d905107
If a cfqueryparam is on more than a single line, subsequent @CFLintIg…
ghedwards Mar 25, 2019
03834fe
Fix matching on @CFLintIgnore comments
ghedwards Mar 25, 2019
ccbe643
QueryParamChecker returning a lot of matches
ghedwards Mar 26, 2019
cbdc7b9
Code quality improvements
ghedwards Mar 26, 2019
84089f8
${variable} might contain a regex expression so make sure its treated…
ghedwards Mar 26, 2019
cf69bce
bugInfo.getColumn() is returning negative values in some cases
ghedwards Mar 29, 2019
31fa568
Merge pull request #1 from ghedwards/prevent-negative-column
ghedwards Mar 29, 2019
6209d91
Merge pull request #2 from ghedwards/queryparamchecker-fix
ghedwards Mar 29, 2019
4ed2dcd
Merge pull request #3 from cflint/master
ghedwards Nov 20, 2019
9e89421
Update file change
achilleus68 Dec 3, 2019
f0f4fc7
#662 Fixing 501 errors
mark-distrokid Jan 24, 2020
412d99b
Merge pull request #663 from cybersonic/dev
ryaneberly Feb 7, 2020
6e14a9b
#670 fixed
ryaneberly Mar 6, 2020
c407986
update libs
ryaneberly Mar 6, 2020
baeb9a8
#670
ryaneberly Mar 6, 2020
c4006c9
#640 fixed
ryaneberly Mar 6, 2020
1772f55
Convert to https (#672)
KamasamaK Mar 6, 2020
7de83ca
Merge pull request #658 from djiest/patch-1
KamasamaK Mar 6, 2020
bfe3221
Upgrade Docker Gradle (#673)
KamasamaK Mar 6, 2020
a55e407
Increment version to v1.5.1-SNAPSHOT (#675)
KamasamaK Mar 18, 2020
15327b3
Adds multiple optimisation, in PackageCaseChecker
xdecock May 16, 2020
806fb4c
use native type, not class on variables
xdecock May 16, 2020
74fd99c
Merge pull request #685 from xdecock/fix/memory-leak-in-PackageCaseCh…
ryaneberly Jun 16, 2020
a3db63b
Merge pull request #622 from ghedwards/prevent-negative-column
ryaneberly Jun 16, 2020
feb924c
Merge pull request #614 from bferdinandus/findbug-xml-format
ryaneberly Aug 21, 2020
52e3a2c
Merge branch 'cflint:master' into queryparamchecker-fix
ghedwards Dec 14, 2023
7c03103
Merge pull request #4 from ghedwards/queryparamchecker-fix
ghedwards Dec 14, 2023
a3fbb5a
Fixing 501 errors
ghedwards Dec 14, 2023
c60b06d
Merge branch 'master' into dev
ghedwards Dec 14, 2023
2b8069f
Update xml libs so everything compiles / passes tests on Java 11
garethedwards-tass Dec 14, 2023
86df2bc
Merge pull request #5 from cfmleditor/dev
ghedwards Dec 14, 2023
7c8364d
gradle build updates for gradle 9
garethedwards-tass Dec 15, 2023
37b02c5
Add evaluate and isdefined as AVOID rules
garethedwards-tass Dec 18, 2023
4ea0049
Merge pull request #6 from cfmleditor/evaluate-isdefined
garethedwards-tass Dec 18, 2023
5671c91
Bump org.apache.ant:ant from 1.7.0 to 1.10.11
dependabot[bot] Mar 5, 2024
86e254d
Bump commons-io:commons-io from 2.5 to 2.7
dependabot[bot] Mar 5, 2024
cd40fa1
Bump com.fasterxml.jackson.core:jackson-databind from 2.10.3 to 2.12.7.1
dependabot[bot] Mar 5, 2024
aba20e1
Bump junit:junit from 4.12 to 4.13.1
dependabot[bot] Mar 5, 2024
3416098
New tag rules (cfinvoke, cfform, cfinput, cffile, cfdirectory)
ghedwards Mar 5, 2024
c7e6e23
Merge pull request #24 from cfmleditor/dependabot/maven/com.fasterxml…
ghedwards Mar 5, 2024
de75ddf
Merge pull request #25 from cfmleditor/dependabot/maven/junit-junit-4…
ghedwards Mar 5, 2024
ad85e40
Merge pull request #23 from cfmleditor/dependabot/maven/commons-io-co…
ghedwards Mar 5, 2024
5a88e91
Merge pull request #22 from cfmleditor/dependabot/maven/org.apache.an…
ghedwards Mar 5, 2024
d1fbeb2
Add cflocation ( missing addtoken ), cfhttp and cfcookie use rules
ghedwards Mar 5, 2024
c77d997
1.5.2-SNAPSHOT
ghedwards Mar 5, 2024
82d40cb
ImplicitScopeChecker ( wip )
ghedwards Mar 6, 2024
71796a5
Improvements to cater for var'd variables and use of top level scope …
ghedwards Mar 6, 2024
6c058d3
Create beforeEndFile scanner event so we can process potential implic…
ghedwards Mar 7, 2024
95c15b2
More implicit scopes, but less strict for now.
ghedwards Mar 7, 2024
71c14b6
Restore list of scopes from implicit scopes, otherwise it reports as …
ghedwards Mar 7, 2024
7114d19
Fix null pointer exception in some conditions
ghedwards Mar 7, 2024
c2b4994
Merge pull request #28 from cfmleditor/ImplicitScopeChecker
ghedwards Mar 8, 2024
a9ff921
1.5.3-SNAPSHOT
ghedwards Mar 13, 2024
a4c08bd
Merge pull request #29 from cfmleditor/ImplicitScopeChecker
ghedwards Mar 13, 2024
2f00e20
Add ATTRIBUTES to list of scopes
ghedwards Mar 14, 2024
2b17d3b
Add cfcatch to implicit scope
ghedwards Mar 14, 2024
7f6e423
Gradle Updates
ghedwards Mar 18, 2024
c42895d
Typos and implicit scope fixes
ghedwards Mar 22, 2024
0aa6701
Fixes for implicitScope checks
ghedwards Mar 22, 2024
0df2c84
1.5.4-SNAPSHOT
ghedwards Mar 22, 2024
61ece9b
Tidy up / Attempt to run scan using Executors
ghedwards Mar 25, 2024
08867c8
Concurrency doesn't work, try again later
ghedwards Mar 25, 2024
c6fa4e7
Tidy up JavaDoc
ghedwards Mar 25, 2024
e8249ae
Update gradle / ant / commons and fix test failure
ghedwards Jan 27, 2025
d20305b
Add Gradle GitHub Action
ghedwards Jan 27, 2025
6662668
Merge branch 'master' of https://github.com/cflint/CFLint into merge-…
ghedwards Jan 27, 2025
a3896ae
Merge fix
ghedwards Jan 27, 2025
d396b87
Revert "Merge fix"
ghedwards Jan 27, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions .github/workflows/gradle.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
name: Gradle

on:
pull_request:
branches:
- main
- master
- dev

jobs:
gradle:
strategy:
Expand All @@ -16,17 +14,12 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v4

- name: Set up JDK 8
- name: Set up JDK 11
uses: actions/setup-java@v4
with:
distribution: temurin
java-version: 8

java-version: 11
- name: Setup Gradle
uses: gradle/actions/setup-gradle@v3
with:
gradle-version: wrapper

- name: Build with Gradle
run: ./gradlew build
3 changes: 3 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"java.configuration.updateBuildConfiguration": "interactive"
}
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
FROM gradle:4.7.0-jdk8-alpine AS build
FROM gradle:5.6.2-jdk8 AS build
COPY --chown=gradle:gradle . /home/gradle/src
WORKDIR /home/gradle/src
RUN gradle build -x test --no-daemon
RUN gradle build -x test --no-daemon

FROM openjdk:8-jre-slim

Expand Down
16 changes: 8 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

A static code analysis tool for CFML.

License: [BSD](http://www.opensource.org/licenses/bsd-license.html)
License: [BSD](https://opensource.org/licenses/bsd-license.html)

Current Version: 1.5.x

Expand Down Expand Up @@ -43,15 +43,15 @@ The master branch is considered our stable codebase. Most of the development hap

## Using CFLint - Quickstart Guide

Get the latest version from [Maven Central](http://search.maven.org/#search%7Cga%7C1%7Ccflint) or the [CFLint GitHub release page](https://github.com/cflint/CFLint/releases) or build the project.
Get the latest version from [Maven Central](https://search.maven.org/search?q=cflint) or the [CFLint GitHub release page](https://github.com/cflint/CFLint/releases) or build the project.

If you want to use CFLint from within another Maven project, use:

```xml
<dependency>
<groupId>com.github.cflint</groupId>
<artifactId>CFLint</artifactId>
<version>1.4.0</version>
<artifactId>cflint</artifactId>
<version>1.4.1</version>
</dependency>
```

Expand All @@ -60,7 +60,7 @@ Or always use the latest:
```xml
<dependency>
<groupId>com.github.cflint</groupId>
<artifactId>CFLint</artifactId>
<artifactId>cflint</artifactId>
<version>LATEST</version>
</dependency>
```
Expand All @@ -69,7 +69,7 @@ With the binaries retrieved one or the other way, you can now use CFLint on the

### Use the "-all"-version of the jar-file

CFLint-1.5.0-all.jar
CFLint-1.5.0-all.jar

### Scan a folder with the complete set of rules

Expand Down Expand Up @@ -234,7 +234,7 @@ The exception is debug mode. In debug mode, CFLint will always ignore user setti

The flag `-html` instructs CFLint to create an HTML document. The full syntax is:

-html -html <outputFileName>
-html -htmlfile <outputFileName>

### XML

Expand Down Expand Up @@ -549,7 +549,7 @@ Note: The back slashes must be escaped twice, once for JSON, once for regular ex

Raise issues here on GitHub and we will look at them.

The [CFML Slack team](http://cfml-slack.herokuapp.com/) has a `#cflint` channel you can join and talk to most of the regular contributors and other users.
The [CFML Slack team](https://cfml-slack.herokuapp.com/) has a `#cflint` channel you can join and talk to most of the regular contributors and other users.

# How to contribute

Expand Down
102 changes: 82 additions & 20 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,29 +2,45 @@ buildscript {
repositories {
mavenLocal()
jcenter {
url "https://jcenter.bintray.com/"
url = "https://jcenter.bintray.com/"
}
maven {
url "https://oss.sonatype.org/content/repositories/snapshots/"
url = "https://oss.sonatype.org/content/repositories/snapshots/"
}
maven {
url "https://plugins.gradle.org/m2/"
url = "https://plugins.gradle.org/m2/"
}
maven {
url = "https://cfmlprojects.org/artifacts"
}
maven {
url "https://cfmlprojects.org/artifacts"
url "https://plugins.gradle.org/m2/"
}
}
dependencies {
classpath 'com.bmuschko:gradle-nexus-plugin:2.3.1'
classpath "io.codearte.gradle.nexus:gradle-nexus-staging-plugin:0.22.0"
classpath "gradle.plugin.se.bjurr.gitchangelog:git-changelog-gradle-plugin:1.64"
// classpath "net.thebugmc.gradle:sonatype-central-portal-publisher:1.2.3"
}
}

plugins {
id 'java'
id 'com.github.johnrengelman.shadow' version '5.2.0'
id 'com.github.johnrengelman.shadow' version '7.1.1'
id 'eclipse'
id 'signing'
// id 'net.thebugmc.gradle.sonatype-central-portal-publisher' version '1.2.3'
}

java {
toolchain {
languageVersion = JavaLanguageVersion.of(11)
vendor = JvmVendorSpec.ADOPTIUM
}

withJavadocJar()
withSourcesJar()
}

// Helper functions and constants
Expand Down Expand Up @@ -56,22 +72,31 @@ def getLatestTag = { ->

apply plugin: "base"
apply plugin: "signing"
apply plugin: "com.bmuschko.nexus"
//apply plugin: "com.bmuschko.nexus"

apply plugin: 'java'
apply plugin: 'maven'
apply plugin: 'maven-publish'
apply from: 'cobertura.gradle'
apply from: 'deploy.gradle'
apply plugin: "se.bjurr.gitchangelog.git-changelog-gradle-plugin"
//apply from: 'deploy.gradle'
apply plugin: 'se.bjurr.gitchangelog.git-changelog-gradle-plugin'
// apply plugin: "net.thebugmc.gradle.sonatype-central-portal-publisher"

sourceCompatibility = 1.8
targetCompatibility = 1.8
sourceCompatibility = 1.11
targetCompatibility = 1.11

repositories {
maven { url "https://oss.sonatype.org/content/repositories/snapshots" }
maven { url "https://repo.maven.apache.org/maven2" }
maven { url "https://oss.sonatype.org/content/repositories/releases" }
maven { url "https://cfmlprojects.org/artifacts" }
maven {
url = "https://oss.sonatype.org/content/repositories/snapshots"
}
maven {
url = "https://repo.maven.apache.org/maven2"
}
maven {
url = "https://oss.sonatype.org/content/repositories/releases"
}
maven {
url = "https://cfmlprojects.org/artifacts"
}
}
dependencies {
implementation group: 'com.github.cfparser', name: 'cfml.parsing', version: '2.11.0'
Expand Down Expand Up @@ -105,9 +130,9 @@ jar {
attributes(
'Main-Class': 'com.cflint.cli.CFLintCLI',
'Implementation-Version': version,
'Bundle-Name': 'CFLint',
'Bundle-SymbolicName': 'com.cflint.CFLint',
'Bundle-Description': 'CFLint',
'Bundle-Name': 'cflint',
'Bundle-SymbolicName': 'io.cfmleditor.cflint',
'Bundle-Description': 'cflint',
'Bundle-ManifestVersion': 2,
'Bundle-Version': version
)
Expand All @@ -117,14 +142,15 @@ jar {
task fatJar(type: Jar) {

manifest.from jar.manifest
classifier = 'all'
archiveClassifier.set('all')
from {
configurations.runtime.collect { it.isDirectory() ? it : zipTree(it) }
configurations.runtimeClasspath.collect { it.isDirectory() ? it : zipTree(it) }
} {
exclude "META-INF/*.SF"
exclude "META-INF/*.DSA"
exclude "META-INF/*.RSA"
}
duplicatesStrategy = DuplicatesStrategy.EXCLUDE
with jar
}

Expand Down Expand Up @@ -154,3 +180,39 @@ task githubChangelogGenerator {
println p.text
}
}

tasks.register('stuffZip', Zip) {
archiveBaseName = 'stuff'
from 'src/stuff'
}

// signing {
// sign stuffZip
// }


// centralPortal {
// pom {
// name = 'cfmleditor-cflint'
// description = 'cflint'
// url = "https://github.com/cfmleditor/CFLint/"
// licenses {
// license {
// name = "bsd-3-clause"
// url = "https://opensource.org/license/bsd-3-clause"
// }
// }
// developers {
// developer {
// name = "Gareth Edwards"
// email = "[email protected]"
// organization = "cfmleditor"
// organizationUrl = "https://github.com/cfmleditor/"
// }
// }
// scm {
// url = "https://github.com/cfmleditor/CFLint/"
// }
// }
// publishingType = USER_MANAGED
// }
4 changes: 2 additions & 2 deletions cobertura.gradle
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
logger.info "Configuring Cobertura Plugin"

configurations{
coberturaRuntime {extendsFrom testRuntime}
coberturaRuntime {extendsFrom testRuntimeOnly}
}

dependencies {
Expand All @@ -15,7 +15,7 @@ def classesCopy="${classes}-copy"

task cobertura(type: Test){
dependencies {
testRuntime 'net.sourceforge.cobertura:cobertura:1.9.4'
testRuntimeOnly 'net.sourceforge.cobertura:cobertura:1.9.4'
}

systemProperty "net.sourceforge.cobertura.datafile", serFile
Expand Down
16 changes: 11 additions & 5 deletions gradle.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
#Tue, 06 Oct 2015 20:08:05 -0600
group=com.github.cflint
version=1.5.0-SNAPSHOT
name=CFLint
#Mon, 18 Mar 2024 11:40:59 +1000
group=io.github.cfmleditor
version=1.5.6-SNAPSHOT
name=cflint
release=false
snapshot=false
snapshot=true
signing.keyId=
signing.password=
signing.secretKeyRingFile=
# sonatype credentials
centralPortal.username=
centralPortal.password=
Binary file modified gradle/wrapper/gradle-wrapper.jar
Binary file not shown.
3 changes: 2 additions & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-6.9.4-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.12.1-bin.zip
networkTimeout=10000
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
Loading
Loading