CFE-4542: Added json promise type#113
Merged
olehermanse merged 1 commit intocfengine:masterfrom Jun 27, 2025
Merged
Conversation
olehermanse
reviewed
Jun 24, 2025
olehermanse
reviewed
Jun 24, 2025
olehermanse
reviewed
Jun 24, 2025
olehermanse
reviewed
Jun 24, 2025
olehermanse
reviewed
Jun 24, 2025
olehermanse
reviewed
Jun 24, 2025
olehermanse
reviewed
Jun 24, 2025
olehermanse
reviewed
Jun 24, 2025
olehermanse
reviewed
Jun 24, 2025
olehermanse
reviewed
Jun 24, 2025
olehermanse
reviewed
Jun 24, 2025
olehermanse
reviewed
Jun 24, 2025
olehermanse
reviewed
Jun 24, 2025
olehermanse
reviewed
Jun 24, 2025
olehermanse
reviewed
Jun 24, 2025
olehermanse
reviewed
Jun 24, 2025
victormlg
force-pushed
the
json-prmise-type
branch
from
c0c3b99 to
c138b14
Compare
victormlg
force-pushed
the
json-prmise-type
branch
3 times, most recently
from
1f2c9b0 to
9975fee
Compare
olehermanse
requested changes
Jun 26, 2025
Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
json-prmise-type
branch
from
9975fee to
40b9903
Compare
larsewi
requested changes
Jun 27, 2025
Contributor
larsewi
left a comment
larsewi
left a comment
There was a problem hiding this comment.
This looks very useful. Thanks for working on it! Added some comments
olehermanse
approved these changes
Jun 27, 2025
Member
olehermanse
left a comment
olehermanse
left a comment
There was a problem hiding this comment.
I don't see anything significant blocking this PR - I think you can review and consider / address all the comments in a smaller followup PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.