Clarify duplicate host management in federated reporting docs#3645
Merged
larsewi merged 3 commits intoMay 13, 2026
Conversation
571c83a to
1d4687e
Compare
craigcomstock
previously requested changes
May 12, 2026
1d4687e to
e21408e
Compare
olehermanse
reviewed
May 12, 2026
olehermanse
reviewed
May 12, 2026
olehermanse
reviewed
May 12, 2026
olehermanse
reviewed
May 12, 2026
olehermanse
reviewed
May 12, 2026
olehermanse
reviewed
May 12, 2026
| A script on the superhub identifies the feeder with the most recent contact for each hostkey and then calls back into the other feeders to delete the stale records at the source, so they are never re-imported. | ||
|
|
||
| There are two options available for handling these situations depending on your environment: Distributed Cleanup or Handle Duplicate Hostkeys. | ||
| - [Handle duplicate hostkeys][Federated reporting#Handle duplicate hostkeys] is a _destination-side_ filter. |
Member
There was a problem hiding this comment.
Out of scope for this PR, but: Handle sounds a bit vague and might be confusing, especially when there is also distributed cleanup, I guess we could rename this mechanism and section to simply Filter duplicate hostkeys.
olehermanse
reviewed
May 12, 2026
olehermanse
reviewed
May 12, 2026
Reframe the "Duplicate host management" intro around the approach distinction rather than separate lifecycle scenarios: both mechanisms address the same underlying problem (same hostkey across multiple feeders), with distributed cleanup as a source-side cleanup and handle duplicate hostkeys as a destination-side filter. Note that neither deduplicates clones reporting to the same feeder, since a feeder's __hosts table is keyed on hostkey. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-authored-by: Ole Herman Schumacher Elgesem <4048546+olehermanse@users.noreply.github.com>
e74e56e to
66fab1f
Compare
olehermanse
reviewed
May 13, 2026
olehermanse
requested changes
May 13, 2026
Member
olehermanse
left a comment
There was a problem hiding this comment.
Looks good, just one small suggestion.
Reframe the "Duplicate host management" intro around the approach distinction rather than separate lifecycle scenarios: both mechanisms address the same underlying problem (same hostkey across multiple feeders), with distributed cleanup as a source-side cleanup and handle duplicate hostkeys as a destination-side filter. Note that neither deduplicates clones reporting to the same feeder, since a feeder's __hosts table is keyed on hostkey. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-authored-by: Ole Herman Schumacher Elgesem <4048546+olehermanse@users.noreply.github.com>
The script has since been changed to ask for admin username and password separately (defaulting to admin) and to prompt for a 2FA code when the admin account has 2FA enabled. Update the bullet list and the example console session to match the current prompts. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
742c8f2 to
fa3acd6
Compare
olehermanse
approved these changes
May 13, 2026
Member
|
@cf-bottom jenkins, please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/28/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-28/output/_site/ |
Member
|
Should be cherry-picked to 3.27 branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dupschema on the superhub during import).__hoststable is keyed on hostkey (verified againstnova/db/schema.sql).distributed_cleanup.pyprompts in the bullet list and the example console session to match the current script: separate admin username/password prompts (defaulting toadmin), and 2FA prompts when enabled.Example output