Skip to content

ENT-10961, CFE-1840: Files promise can now modify immutable bit in file system attributes #5694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

larsewi
Copy link
Contributor

@larsewi larsewi commented Feb 6, 2025

Merge together with NorthernTechHQ/libntech#235

Build Status

@cf-bottom
Copy link

Thanks for submitting a pull request! Maybe @craigcomstock can review this?

@larsewi larsewi force-pushed the immutable branch 3 times, most recently from c5e1a67 to 43ef275 Compare February 18, 2025 15:17
@larsewi larsewi force-pushed the immutable branch 4 times, most recently from 3bfbc92 to a3058d3 Compare February 27, 2025 09:40
@larsewi larsewi marked this pull request as ready for review March 5, 2025 16:31
Copy link
Contributor

@craigcomstock craigcomstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! A few nitpicks.

@larsewi larsewi force-pushed the immutable branch 5 times, most recently from 3de1772 to e33b4d3 Compare March 6, 2025 10:39
@larsewi larsewi requested a review from craigcomstock March 6, 2025 10:42
@larsewi larsewi force-pushed the immutable branch 6 times, most recently from 2d128d0 to bbbd1f7 Compare March 7, 2025 11:20
larsewi added 2 commits March 7, 2025 13:33
Added syntax for `body fsattrs` with a boolean constraint `immutable`.
It currently does nothing, but this will change in following commits.

Ticket: ENT-10961, CFE-1840
Signed-off-by: Lars Erik Wik <[email protected]>
Ticket: ENT-10961, CFE-1840
Changelog: Title
Signed-off-by: Lars Erik Wik <[email protected]>
@larsewi larsewi force-pushed the immutable branch 2 times, most recently from 13802bc to 389becb Compare March 7, 2025 14:35
Ticket: ENT-10961, CFE-1840
Signed-off-by: Lars Erik Wik <[email protected]>
@larsewi larsewi marked this pull request as draft April 1, 2025 12:15
@larsewi
Copy link
Contributor Author

larsewi commented Apr 1, 2025

Is superseded by #5752

@larsewi larsewi closed this Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants