CFE-4405: Added curl installation check when remote download #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olehermanse
reviewed
Apr 24, 2025
Ticket: CFE-4405 Signed-off-by: Victor Moene <[email protected]>
victormlg
force-pushed
the
curl_not_installed
branch
from
06b1b00 to
235622e
Compare
olehermanse
requested changes
Apr 25, 2025
| @@ -515,6 +515,12 @@ def install_host( | |||
| return 1 | |||
|
|
|||
| if remote_download: | |||
| if data.get("bin") and not data.get("bin").get("curl"): | |||
There was a problem hiding this comment.
dict.get() returns None by default if the key is not found, so if you try to run .get() on that, you get AttributeError.
You can give an empty dict as a default value, so the last .get() also works:
Suggested change
| if data.get("bin") and not data.get("bin").get("curl"): | |
| if data.get("bin") and not data.get("bin", {}).get("curl"): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.