Skip to content

ENT-12619: Filter known-benign warnings in run_and_print_on_failure #2112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
larsewi merged 1 commit into from
Feb 13, 2026
Merged

ENT-12619: Filter known-benign warnings in run_and_print_on_failure #2112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions build-scripts/functions
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -754,10 +754,20 @@ run_and_print_on_failure() {
# Filter output on Warnings/Errors and add two lines of context
regex='([Ww]arning:|[Ee]rror:)'
if grep_q -E "$regex" "$temp_output_file"; then
log_debug "Found warnings/errors in output from command:" "$@"
echo "--- Start of Warnings/Errors ---"
grep_c 2 -E "$regex" "$temp_output_file"
echo "--- End of Warnings/Errors ---"
# Known-benign patterns that are not actionable and should be suppressed:
# - automake subdir-objects: forward-compatibility notice, harmless
# - libtool install warnings: normal when using DESTDIR
# shellcheck disable=SC3043
local benign='subdir-objects|libtool: warning: remember to run|libtool: warning:.*has not been installed|libtool: install:'
# shellcheck disable=SC3043
local filtered
filtered=$(grep_c 2 -E "$regex" "$temp_output_file" | grep -v -E "$benign") || true
if [ -n "$filtered" ]; then
log_debug "Found warnings/errors in output from command:" "$@"
echo "--- Start of Warnings/Errors ---"
printf '%s\n' "$filtered"
echo "--- End of Warnings/Errors ---"
fi
fi
else
# Print all output
Expand Down