In CI scripts, nodesource.com is often flaky, instead check if sufficient node version is already present#2044
Closed
craigcomstock wants to merge 3 commits intocfengine:masterfrom
Closed
Conversation
Contributor
craigcomstock
commented
Nov 19, 2025
craigcomstock
commented
- Tidy up ci/setup.sh based on shellcheck linter
- In CI scripts, nodesource.com is often flaky, instead check if sufficient node version is already present
Ticket: none Changelog: none
…ient node version is already present Especially in github we have seend deb.nodesource.com not work repeatedly. The image we currently use on github includes a sufficient node, v20.19.5 so no need to install something else there. https://github.com/actions/runner-images/blob/ubuntu22/20251112.150/images/ubuntu/Ubuntu2204-Readme.md Ticket: ENT-13521 Changelog: none
craigcomstock
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.