bootstrap-tarballs: Document script #1757
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: ENT-12600 Signed-off-by: Lars Erik Wik <[email protected]>
Ticket: ENT-12600 Signed-off-by: Lars Erik Wik <[email protected]>
Ticket: ENT-12600 Signed-off-by: Lars Erik Wik <[email protected]>
I feel like the installation of dependencies does not belong here. Maybe they should go in to the install-dependencies script? Ticket: ENT-12600 Signed-off-by: Lars Erik Wik <[email protected]>
Signed-off-by: Lars Erik Wik <[email protected]>
Signed-off-by: Lars Erik Wik <[email protected]>
The use of `|| true` will cause an error message to be printed by `rm` which may lead QA personnel to believe that there is something wrong while there is not. -f will simply ignore nonexistent files. ``` rm: cannot remove 'nosuchfile': No such file or directory ``` Signed-off-by: Lars Erik Wik <[email protected]>
Signed-off-by: Lars Erik Wik <[email protected]>
Added a comment to the top of the file explaining what the script does and how you can run it. Ticket: ENT-12600 Signed-off-by: Lars Erik Wik <[email protected]>
larsewi
force-pushed
the
bootstrap-tarballs
branch
from
b762ba5 to
0bcf793
Compare
| # sure that they actually work. | ||
| # | ||
| # Currently this script also fetches pull request info and installs PHP and | ||
| # javascript dependencies. This core really does not belong here. Created a |
There was a problem hiding this comment.
Suggested change
| # javascript dependencies. This core really does not belong here. Created a | |
| # javascript dependencies. This code really does not belong here. I created a |
| # . | ||
| # ├── buildscripts | ||
| # ├── core | ||
| # ├── enterprise |
There was a problem hiding this comment.
if PROJECT=community you don't need all the ent stuff. Maybe clarify that with separate lists?
Comment on lines
+41
to
+42
| # Get information about PRs among the used revisions. These PRs will have to be | ||
| # notified of build progress. |
There was a problem hiding this comment.
Suggested change
| # Get information about PRs among the used revisions. These PRs will have to be | |
| # notified of build progress. | |
| # Get information about PRs among the used revisions. | |
| # These PRs will have to be notified of build progress. |
I would somewhat prefer a sentence per line honestly. easier for maintenance and editing.
Comment on lines
+122
to
+123
| if test -f "$BASEDIR"/mission-portal/public/scripts/package.json; then | ||
| cd "$BASEDIR"/mission-portal/public/scripts |
There was a problem hiding this comment.
This change isn't so needed but is fine. I often prefer to avoid the quotes as if more vars enter the expression things get noisy.
| fi | ||
| ) | ||
|
|
||
| echo "$(basename "$0"): Debug: Installing PHP dependencies from mission-portal repository..." |
There was a problem hiding this comment.
Suggested change
| echo "$(basename "$0"): Debug: Installing PHP dependencies from mission-portal repository..." | |
| echo "$(basename "$0"): Debug: Installing PHP composer dependencies from mission-portal repository..." |
| CKSUM=$(sum sha256sums.txt | cut -d ' ' -f 1) | ||
| mv sha256sums.txt sha256sums."$CKSUM".txt | ||
|
|
||
| echo "$(basename "$0"): Debug: Installing javascript dependencies..." |
There was a problem hiding this comment.
Suggested change
| echo "$(basename "$0"): Debug: Installing javascript dependencies..." | |
| echo "$(basename "$0"): Debug: Installing javascript npm dependencies..." |
| fi | ||
| ) | ||
|
|
||
| echo "$(basename "$0"): Debug: Installing PHP dependencies from nova repository..." |
There was a problem hiding this comment.
Suggested change
| echo "$(basename "$0"): Debug: Installing PHP dependencies from nova repository..." | |
| echo "$(basename "$0"): Debug: Installing PHP composer dependencies from nova repository..." |
| fi | ||
| ) | ||
|
|
||
| echo "$(basename "$0"): Debug: Installing LDAP API dependencies..." |
There was a problem hiding this comment.
Suggested change
| echo "$(basename "$0"): Debug: Installing LDAP API dependencies..." | |
| echo "$(basename "$0"): Debug: Installing LDAP API PHP composer dependencies..." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example output:
I snipped out noise from sourced scripts.
With exotics (no tests)
Failures are unrelated: