ENT-12600: Document and refactor compile-options #1744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lars Erik Wik <[email protected]>
We don't really build with something else then lmdb. Hence, we don't need the option to build with something else. Signed-off-by: Lars Erik Wik <[email protected]>
Ticket: ENT-12600 Signed-off-by: Lars Erik Wik <[email protected]>
|
Thank you for submitting a pull request! Maybe @craigcomstock can review this? |
Ticket: ENT-12600 Signed-off-by: Lars Erik Wik <[email protected]>
Ticket: ENT-12600 Signed-off-by: Lars Erik Wik <[email protected]>
Comment on lines
+68
to
+71
| # HP-UX ships with ‘cc’ which invokes the ‘HP-UX bundled C compiler’ which | ||
| # lacks some functionality we need to build things. Among the other things, | ||
| # it doesn’t know how to link ‘.so’ files directly and it doesn’t recognize | ||
| # them as valid input type. |
There was a problem hiding this comment.
Suggested change
| # HP-UX ships with ‘cc’ which invokes the ‘HP-UX bundled C compiler’ which | |
| # lacks some functionality we need to build things. Among the other things, | |
| # it doesn’t know how to link ‘.so’ files directly and it doesn’t recognize | |
| # them as valid input type. | |
| # HP-UX ships with ‘cc’ which invokes the ‘HP-UX bundled C compiler’ which lacks some functionality we need to build things. Among the other things, it doesn’t know how to link ‘.so’ files directly and it doesn’t recognize them as valid input type. |
Comment on lines
+109
to
+110
| # Win32 does not support pthreads natively. The pthreads-w32 project provide | ||
| # solution to this problem. |
There was a problem hiding this comment.
Suggested change
| # Win32 does not support pthreads natively. The pthreads-w32 project provide | |
| # solution to this problem. | |
| # Win32 does not support pthreads natively. The pthreads-w32 project provide solution to this problem. |
Comment on lines
+113
to
+114
| # A port of the regex functionality from the glibc Library for use on | ||
| # Windows platforms |
There was a problem hiding this comment.
Suggested change
| # A port of the regex functionality from the glibc Library for use on | |
| # Windows platforms | |
| # A port of the regex functionality from the glibc Library for use on Windows platforms. |
Comment on lines
+122
to
+123
| # libgcc_s.so is needed before we compile any other dependency | ||
| # on some platforms! |
There was a problem hiding this comment.
Suggested change
| # libgcc_s.so is needed before we compile any other dependency | |
| # on some platforms! | |
| # libgcc_s.so is needed before we compile any other dependencies on some platforms! |
Is it specifically libgcc_s.so or is it the gcc command? Curious.
Comment on lines
+145
to
+146
| # Generic library that implements the Simple Authentication and Security | ||
| # Layer (SASL) framework |
There was a problem hiding this comment.
Suggested change
| # Generic library that implements the Simple Authentication and Security | |
| # Layer (SASL) framework | |
| # Generic library that implements the Simple Authentication and Security Layer (SASL) framework |
Comment on lines
+175
to
+179
| # Library for managing Extended Attributes (xattrs) on filesystems | ||
| var_append DEPS "libattr" | ||
|
|
||
| # POSIX Access Control Lists (ACLs) on filesystems | ||
| var_append DEPS "libacl" |
There was a problem hiding this comment.
might be interesting to note if (and I think they are) dependencies of apache?
| nova-s390*-*-*) | ||
| ROLE=agent | ||
| ;; | ||
| nova-*-centos-*) |
There was a problem hiding this comment.
This section could use a comment near the top. Why do we assume hub for platforms that support it? Interesting.
| nova-*-debian-*) | ||
| ROLE=hub | ||
| ;; | ||
| nova-*-opensuse-*) |
There was a problem hiding this comment.
we don't support hub on opensuse.
| nova-*-rhel-*) | ||
| ROLE=hub | ||
| ;; | ||
| nova-*-sles-*) |
There was a problem hiding this comment.
no support for sles hub
Comment on lines
+295
to
+297
| # We install in all Linux platforms, because it does no harm on platforms | ||
| # without systemd, and it has the advantage of working out of the box on | ||
| # platforms that adopt systemd later. |
There was a problem hiding this comment.
Suggested change
| # We install in all Linux platforms, because it does no harm on platforms | |
| # without systemd, and it has the advantage of working out of the box on | |
| # platforms that adopt systemd later. | |
| # We install in all Linux platforms, because it does no harm on platforms without systemd, and it has the advantage of working out of the box on platforms that adopt systemd later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.