Added logs for humans #1591
Open
Added logs for humans #1591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting a PR! Maybe @craigcomstock can review this? |
| init_postgres_dir "$new_pgconfig_file" "$pgconfig_type" | ||
| fi | ||
| if is_upgrade && [ -d "$BACKUP_DIR/data" ]; then | ||
| cf_console echo "Upgrade & BACKUP_DIR/data is present, proceeding with db migration" |
There was a problem hiding this comment.
Suggested change
| cf_console echo "Upgrade & BACKUP_DIR/data is present, proceeding with db migration" | |
| cf_console echo "Upgrade and BACKUP_DIR/data is present, proceeding with full database migration." |
There was a problem hiding this comment.
aka "full database migration" is my phrase for what is described here: https://www.postgresql.org/docs/current/upgrading.html
| do_migration "$new_pgconfig_file" "$pgconfig_type" | ||
| else | ||
| cf_console echo "No db migration necessary, skipping" |
There was a problem hiding this comment.
Suggested change
| cf_console echo "No db migration necessary, skipping" | |
| cf_console echo "Major version of PostgreSQL did not change so simple migration will occur." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.