intelmqctl: On stop wait longer for bots to be stopped #2598
Conversation
|
the 3.10 pytest fail is unrelated (see #2602) |
|
I put quite some comments in there. Looking at the other code, I see much less comments. If I should shrink the comments just let me know. |
Please not, inline comments are great :) |
|
Alright then. The tests (that shall pass) pass. Any additional feedback? (also notify if not, so I can squash the commits into one commit) |
retry multiple times on `intelmqctl stop` to check if bots really stopped, since the bots might take longer to stop. Using retry in constrast to increasing the sleep_time keeps the delay short in case the bots did already stop.
|
Is there something still blocking the merge? (please don't feel pressured, I just want to avoid this got lost in the whole fixing the pytest pipelines issue) |
|
Friendly reminder for this PR. |
A code review and testing (+ changelog entry, but that's minor). Most of us do that work honorary, so it's sometimes hard to find the time. |
fixes #2595
retry multiple times on
intelmqctl stopto check if bots really stopped, since the bots might take longer to stop. Using retry in constrast to increasing the sleep_time keeps the delay short in case the bots did already stop.Note: I intend to make at least the amount of retries performed configurable so that if the current total
sleep_timeof 4.75 seconds does not suffice for some users they are able to increase it.