Skip to content

Trashbin features #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2025
Merged

Trashbin features #205

merged 2 commits into from
Aug 15, 2025

Conversation

diocas
Copy link

@diocas diocas commented Aug 12, 2025

Ported from the current web.

I wanted something cleaner for the UI error when the response is 400... I'm open to suggestions; otherwise, it goes as is and then we improve later.

Also, had to import v-calendar again, since oC no longer uses it and there was no cleaner option for range selection.

Copy link

@rodcoffani rodcoffani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding v-calendar again seems to be the way to go.
Just some fixes are needed:

  • The request sent is not the last one selected
  • Maybe adding "in the selected time period" to the empty response feedback?

diocas added 2 commits August 15, 2025 09:56
No default value is sent to the server. The server will apply its own defaults.
@rodcoffani
Copy link

Added a fix for the timezone, now the first selection also works :)

@rodcoffani rodcoffani self-requested a review August 15, 2025 07:58
@rodcoffani rodcoffani merged commit 6db4f6e into dev Aug 15, 2025
@rodcoffani rodcoffani deleted the feat/trashbin branch August 15, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants