Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container/Containerfile: use ganesha-4 from proper path #60936

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

dmick
Copy link
Member

@dmick dmick commented Dec 4, 2024

Same as ceph/ceph-container#2253

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@github-actions github-actions bot added this to the quincy milestone Dec 4, 2024
@dmick dmick requested a review from ktdreyer December 4, 2024 08:18
@dmick
Copy link
Member Author

dmick commented Dec 4, 2024

I will merge this after the backport of #60755

@dmick dmick force-pushed the wip-quincy-ganesha-version branch from 101c84d to b8aa44b Compare December 10, 2024 00:46
@dmick
Copy link
Member Author

dmick commented Dec 10, 2024

rebased to include recent changes in main container code

@dmick
Copy link
Member Author

dmick commented Dec 10, 2024

@ktdreyer if you would

@@ -14,7 +14,7 @@ ARG CEPH_SHA1
ARG CEPH_GIT_REPO

# (optional) Define the baseurl= for the ganesha.repo
ARG GANESHA_REPO_BASEURL="https://buildlogs.centos.org/centos/\$releasever-stream/storage/\$basearch/nfsganesha-5/"
ARG GANESHA_REPO_BASEURL="https://mirror.stream.centos.org/SIGs/centos/\$releasever-stream/storage/\$basearch/nfsganesha-4/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://mirror.stream.centos.org/SIGs/centos/9-stream/storage/x86_64/nfsganesha-4/repodata/repomd.xml is a 404

This works: https://mirror.stream.centos.org/SIGs/9-stream/storage/x86_64/nfsganesha-4/, so I think the diff should be (untested):

Suggested change
ARG GANESHA_REPO_BASEURL="https://mirror.stream.centos.org/SIGs/centos/\$releasever-stream/storage/\$basearch/nfsganesha-4/"
ARG GANESHA_REPO_BASEURL="https://mirror.stream.centos.org/SIGs/\$releasever-stream/storage/\$basearch/nfsganesha-4/"

@dmick dmick force-pushed the wip-quincy-ganesha-version branch from b8aa44b to 01a8111 Compare December 19, 2024 08:02
@dmick
Copy link
Member Author

dmick commented Dec 19, 2024

absolutely right. Built a quincy container to verify.

@dmick dmick requested a review from yuriw January 15, 2025 20:29
@dmick
Copy link
Member Author

dmick commented Jan 15, 2025

Maybe we just close this now that we're done with quincy?...

@yuriw yuriw merged commit 3edb8ea into ceph:quincy Jan 30, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants