-
Notifications
You must be signed in to change notification settings - Fork 13
fix(drawer): fix bug with navigation #1752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(drawer): fix bug with navigation #1752
Conversation
🦋 Changeset detectedLatest commit: f806966 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Screencast from 23.04.25 18:52:01.webm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drawer fix is good 👍
DatePicker: I am revisiting this and on both our dev link and this PR, I am able to navigate with up and down arrows without needing to use Command. I am not able to reproduce the original bug, so I am not sure this fix is needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is now only a change for NavTabs/Drawer, can we update the changeset, PR title and descriptions?
Closes: #1561
What I did
Fix bug with navigation for Drawer.
Screenshots
Checklist
How to test
MacOS + Safari -> Open Storybook -> Drawer -> Press
Tab
-> Verify that focus moves as expected.