Skip to content

fix(drawer): fix bug with navigation #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2025

Conversation

nikitaorliak-cengage
Copy link
Collaborator

@nikitaorliak-cengage nikitaorliak-cengage commented Apr 23, 2025

Closes: #1561

What I did

Fix bug with navigation for Drawer.

Screenshots

Checklist

  • changeset has been added
  • Pull request is assigned, labels have been added and ticket is linked
  • Pull request description is descriptive and testing steps are listed
  • Corresponding changes to the documentation have been made
  • New and existing unit tests pass locally with the proposed changes
  • Tests that prove the fix is effective or that the feature works have been added

How to test

MacOS + Safari -> Open Storybook -> Drawer -> Press Tab -> Verify that focus moves as expected.

Copy link

changeset-bot bot commented Apr 23, 2025

🦋 Changeset detected

Latest commit: f806966

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-magma-dom Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Copy link
Contributor

Copy link
Collaborator

@olehnoskov-cengage olehnoskov-cengage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@silvalaura silvalaura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drawer fix is good 👍
DatePicker: I am revisiting this and on both our dev link and this PR, I am able to navigate with up and down arrows without needing to use Command. I am not able to reproduce the original bug, so I am not sure this fix is needed?

Copy link
Contributor

Copy link
Contributor

Copy link
Collaborator

@silvalaura silvalaura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is now only a change for NavTabs/Drawer, can we update the changeset, PR title and descriptions?

@nikitaorliak-cengage nikitaorliak-cengage changed the title fix(drawer, datepicker): fix bugs with navigation fix(drawer): fix bugs with navigation May 28, 2025
@nikitaorliak-cengage nikitaorliak-cengage changed the title fix(drawer): fix bugs with navigation fix(drawer): fix bug with navigation May 28, 2025
Copy link
Contributor

Copy link
Contributor

@nikitaorliak-cengage nikitaorliak-cengage merged commit 62b58ab into dev May 30, 2025
2 checks passed
@nikitaorliak-cengage nikitaorliak-cengage deleted the fix/Drawer-and-DatePicker-navigation-bugs branch May 30, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Pull requests that are ready for developer review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drawer & DatePicker: focus does not lock in Safari
4 participants