-
Notifications
You must be signed in to change notification settings - Fork 213
Add iOS build with bls #528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
8cfa907
5ce82b7
da88d4c
5d0de52
738b8aa
f16308b
a36e3a0
2d1d8ca
fa533cb
902f334
22e0e43
c8adc6a
4a466e0
73653b2
084b2de
2a69428
33ecf24
bb1ed1f
42caff5
4498015
2dba9f4
691d471
4227e14
b804fd1
eb12e5a
e81436d
d2127b7
6ab3809
d52fd6b
f77b6d9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,6 +29,7 @@ target | |
/build/bin/* | ||
!/build/bin/geth.aar | ||
/geth*.zip | ||
ndk_bundle | ||
|
||
# travis | ||
profile.tmp | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
require 'json' | ||
|
||
package = JSON.parse(File.read(File.join(__dir__, 'package.json'))) | ||
|
||
Pod::Spec.new do |s| | ||
s.name = 'CeloBlockchain' | ||
s.version = package['version'] | ||
s.license = package['license'] | ||
s.homepage = package['homepage'] | ||
s.authors = { 'Connor McEwen' => '[email protected]' } | ||
s.summary = package['description'] | ||
s.source = { :git => package['repository']['url'], :tag => s.version } | ||
s.source_files = 'build/bin/Geth.framework/**/*.h', 'Empty.m' | ||
s.vendored_libraries = 'libGeth.a', 'vendor/github.com/celo-org/bls-zexe/bls/target/universal/release/libbls_zexe.a' | ||
s.pod_target_xcconfig = { 'OTHER_LDFLAGS' => '-ObjC' } | ||
end |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -942,6 +942,8 @@ func doXCodeFramework(cmdline []string) { | |
|
||
// Build the iOS XCode framework | ||
build.MustRun(goTool("get", "golang.org/x/mobile/cmd/gomobile", "golang.org/x/mobile/cmd/gobind")) | ||
// Patch gomobile to disable bitcode for now (rust generated bls lib output is not compatible) | ||
build.MustRunCommand("sed", "-i", "", `/^[[:space:]]*cflags += \" -fembed-bitcode\"$/s/^/\/\//`, filepath.Join(build.GOPATH(), "src/golang.org/x/mobile/cmd/gomobile/env.go")) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Too bad it doesn't work :( There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I tried with Rust 1.38 stable and 1.40.0-nightly (2748a9fd9 2019-10-08). |
||
bind := gomobileTool("bind", "-ldflags", "-s -w", "--target", "ios", "--tags", "ios", "-v", "github.com/ethereum/go-ethereum/mobile") | ||
|
||
if *local { | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't there an endif missing here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question 👍 this syntax works but someone mentions it's failing with GNU Make 3.80:
https://stackoverflow.com/a/12297193/158525
My machine has GNU Make 3.81 which was first released in 2006.
I think we're safe, but let me know if you still wanna change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I just changed the structure anyway so no questions about this anymore :D