Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping Dependencies (inc. pyproject.toml) #436

Merged
merged 3 commits into from
Feb 21, 2025
Merged

Conversation

Nusnus
Copy link
Member

@Nusnus Nusnus commented Nov 20, 2024

No description provided.

@Nusnus Nusnus self-assigned this Nov 20, 2024
@Nusnus Nusnus added the dependencies Pull requests that update a dependency file label Nov 20, 2024
Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.80%. Comparing base (61efdbc) to head (bb3dcf0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #436   +/-   ##
=======================================
  Coverage   23.80%   23.80%           
=======================================
  Files          41       41           
  Lines        1294     1294           
  Branches       94       94           
=======================================
  Hits          308      308           
  Misses        959      959           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR enhances security in GitHub Actions workflows and updates dependency version constraints in pyproject.toml for better Python version compatibility.

  • Added explicit OIDC authentication for Codecov uploads in .github/workflows/python-package.yml with use_oidc: true
  • Updated setuptools constraints in pyproject.toml to 60.0.0-75.0.0 for Python 3.8 and >=75.5.0 for Python 3.9+
  • Bumped debugpy to 1.8.8 and mypy to 1.13.0 in pyproject.toml
  • Added Python version-specific constraints for pytest-cov and pytest-rerunfailures in pyproject.toml
  • Added explicit permissions for Unit job with contents: read and id-token: write in workflow file

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@Nusnus Nusnus force-pushed the hotfix branch 4 times, most recently from 9738a08 to 7f7ddec Compare February 20, 2025 22:52
@Nusnus Nusnus force-pushed the hotfix branch 18 times, most recently from 76f0a1b to c3a0bea Compare February 21, 2025 09:19
@Nusnus Nusnus marked this pull request as ready for review February 21, 2025 09:38
@Nusnus Nusnus merged commit 260e57b into celery:main Feb 21, 2025
39 checks passed
@Nusnus Nusnus deleted the hotfix branch February 21, 2025 09:38
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR focuses on standardizing Poetry version management and updating dependency configurations across the project. Here's a concise summary of the key changes:

  • Standardized Poetry version to 1.8.4 across all GitHub Actions workflows and ReadTheDocs configuration
  • Modified ReadTheDocs build process to use poetry export for generating requirements.txt instead of direct Poetry installation
  • Added new PyPI history page link pattern to docs/conf.py linkcheck_ignore list
  • Updated urllib3 (<2.0), psutil (>=7.0.0), and debugpy (1.8.12) version constraints in pyproject.toml

The changes ensure consistent dependency management and build processes across different environments while maintaining compatibility with various Python versions.

6 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

Comment on lines 107 to +109
uses: snok/[email protected]
with:
version: 1.8.4
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Duplicate Poetry installation configuration. Consider using a reusable workflow or composite action to avoid repetition.

Comment on lines +158 to +159
{ version = "*", python = ">=3.8,<3.9" },
{ version = "^0.14.0", python = ">=3.9,<4.0" },
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Using '*' as version specifier for pytest-subtests on Python 3.8 could lead to incompatibility issues. Consider specifying a version range.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant