Run management command in tox. #574
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run the `celery` management command, to detect breakage there. This should be more exaustive (though I'm not sure which commands will work with the celery config here?), it should be enough to check if the management command fails. NOTE: I can't run tox here to see if this works.
Update path to manage.py
|
Hi, S |
|
can help to fix the management command as well |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the tox configuration to run the celery management command so that any breakage in the celery integration can be detected early.
- Adds a command to invoke "tests/manage.py celery" within the tox test suite.
- Aims to catch issues like those described in bug TypeError: can only concatenate list (not "tuple") to list #573.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run the
celerymanagement command, to detect breakage there.This should be more exaustive (though I'm not sure which commands will work with the celery config here?), it should be enough to check if the management command fails.
This is to try and detect bugs like #573
It looks like there have been similar bugs recently in the tracker too.
NOTE: I can't run tox here to see if this works.This fails in tox, so seems to be correct.