Update Django/Python support #458
Conversation
And copy required pytest fixtures from Celery celery/celery#7077
browniebroke
force-pushed
the
update/django-python-support
branch
from
a44b7a9 to
9033da2
Compare
browniebroke
force-pushed
the
update/django-python-support
branch
from
bf04f86 to
146e65a
Compare
requirements/test.txt
Outdated
| @@ -1,4 +1,3 @@ | |||
| case>=1.3.1 | |||
There was a problem hiding this comment.
This one might deserve its own separate PR... Thoughts?
t/conftest.py
Outdated
| """ | ||
| return _patching(monkeypatch, request) | ||
|
|
||
|
|
||
| @pytest.fixture(autouse=True) | ||
| def test_cases_shortcuts(request, app, patching): |
There was a problem hiding this comment.
As far as I can tell, the patching fixture was only thing that was coming from the case dependency. I took the current implementation from Celery (found here celery/celery#7077)
Not sure if duplicating these ~100 lines of code is the best way forward but that does the job
There was a problem hiding this comment.
we might be using that from celery instead of case if those are already available there
There was a problem hiding this comment.
or we can handle this in a separate PR
There was a problem hiding this comment.
The version from Celery is defined under the tests directory (celery/t), which not included in the wheel distribution, so it's not available in the version we have installed... I tried to install from the source distribution, which seems to have the t directory included, but couldn't get to import the fixture.
There was a problem hiding this comment.
So I have 2 approaches:
- Extract the commit as is from this PR Remove case dependency and copy Celery fixture #462 - just works but fixture is duplicated with Celery
- Use the fixture from Celery PoC: Remove case dependency and use Celery fixture #461 - not working right now, so I assume it needs more work in Celery... Perhaps move the fixture from
tto underceleryto be included in the distribution, but I'm not sure about the side effects of doing so.
Approach 1 is more practical, and can unblock this PR immediately. Approach 2 is more purist but needs more work and guidance from one of the Celery maintainers.
t/conftest.py
Outdated
| """ | ||
| return _patching(monkeypatch, request) | ||
|
|
||
|
|
||
| @pytest.fixture(autouse=True) | ||
| def test_cases_shortcuts(request, app, patching): |
There was a problem hiding this comment.
or we can handle this in a separate PR
EDIT: right I just saw that #456 was merged in the meantime... What is your plan in terms of adding and removing support? |
EDIT: perhaps duplicated with #456
Fix #420