-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(admin): add task field to search_fields #857
Conversation
Extended the search functionality in the PeriodicTaskAdmin by adding 'task' to the search_fields. This allows users to search periodic tasks by their task names, improving the admin interface usability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please check why the builds are failing?
It looks like the builds were failing due to a flaky test ( The test does not account for the default Celery cleanup task hour, causing it to fail when ran at specific times. I do not think fixing this test is within scope of this PR, but I'm happy to open a separate PR to address it. Let me know how you would like me to approach it. e.g. freezing time, assert only if statements do not result in '4', etc. |
it would be highly appreciated if you can open a separate PR to address this flaky test. I will ping @alirafiei75 to review it |
Here's the PR that will remove the flake from `t/unit/test_schedulers.py::test_DatabaseScheduler::test_get_excluded_hours_for_crontab_tasks 🙏 |
I have reviewed the mentioned PR and approved it. @kyonlee thanks for fixing the test. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #857 +/- ##
=======================================
Coverage 87.42% 87.42%
=======================================
Files 32 32
Lines 954 954
Branches 76 76
=======================================
Hits 834 834
Misses 102 102
Partials 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Extended the search functionality in the PeriodicTaskAdmin by adding 'task' to the search_fields. This allows users to search periodic tasks by their task names, improving the admin interface usability.
Issue: #856