Fix database migrations #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking forward to it |
moseb
force-pushed
the
issue-217-fix-migrations
branch
11 times, most recently
from
e5c4d03 to
5fdf91a
Compare
liquidpele
suggested changes
May 3, 2019
| @@ -1,95 +0,0 @@ | |||
| # Generated by Django 2.1.2 on 2018-10-12 14:18 | |||
There was a problem hiding this comment.
So you deleted the squashed migration here, but that shipped in 1.4.0. I'm surprised that it didn't complain about it being in the migrations table later on upgrade, but I guess if it works it works /shrug
moseb
force-pushed
the
issue-217-fix-migrations
branch
from
5fdf91a to
8032046
Compare
|
@moseb looks like flake8 is failing now due to the comment... but I'm not sure what BEGIN ex and END ex mean. Maybe say something like |
auvipy
approved these changes
May 3, 2019
moseb
force-pushed
the
issue-217-fix-migrations
branch
from
8032046 to
1d4c465
Compare
auvipy
approved these changes
May 6, 2019
|
Thanks! |
|
Awesome, thanks @moseb for the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meant to address issue #217