-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration tests, fix migration bug, and clean up test matrix. #244
Conversation
@liquidpele are you going to do this for all versions? |
Yes, just playing with getting one working first... tox and travis-ci are finicky AF. |
I recommend looking here: #210 and not squashing the migration. You will have users in different spots and this will never work for all |
Seems you are going to be martyred for fixing this 🗡️ |
Ha. Such an annoying issue. I can't reproduce it anywhere except the damn travis-ci environment! |
I think this is finally done! Apparently the issue I was debugging was a but with django migrations and older sqlite.... basically it would just randomly fail saying that a field didn't exist, but re-running the same test again would make it pass, and I couldn't reproduce it locally. Updating all tests to run on xenial seems to have stopped the failures. |
In this PR: