Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration tests, fix migration bug, and clean up test matrix. #244

Merged
merged 47 commits into from
May 1, 2019

Conversation

liquidpele
Copy link
Contributor

@liquidpele liquidpele commented Apr 29, 2019

In this PR:

  1. Set up tests to upgrade from 1.1.1, 1.20, 1.3.0, 1.4.0. After upgrade, run migrations back to 0001 and then forward again to ensure no issues.
  2. Add a migration to remove bad migration history caused by the migration squash a while back. This was only causing an error when ugprading from 1.3.0 and then going backward again, caught by the new tests mentioned above.
  3. Update all test VMs to xenial (ubuntu 6.04). Add erlang fixing code to a central location for all builds.
  4. Ensure we get latest sqlite due to a very strange timing bug with sqlite and migrations that would cause migrations to randomly fail.
  5. Add python 3.6, and django 2.1 to text matrix.

@justmobilize
Copy link

@liquidpele are you going to do this for all versions?

@liquidpele
Copy link
Contributor Author

Yes, just playing with getting one working first... tox and travis-ci are finicky AF.

@justmobilize
Copy link

I recommend looking here: #210 and not squashing the migration. You will have users in different spots and this will never work for all

@auvipy
Copy link
Member

auvipy commented May 1, 2019

Seems you are going to be martyred for fixing this 🗡️

@liquidpele
Copy link
Contributor Author

Ha. Such an annoying issue. I can't reproduce it anywhere except the damn travis-ci environment!

@liquidpele liquidpele changed the title First pass at doing an upgrade test Migration tests, fix migration bug, and clean up test matrix. May 1, 2019
@liquidpele
Copy link
Contributor Author

@auvipy @justmobilize

I think this is finally done! Apparently the issue I was debugging was a but with django migrations and older sqlite.... basically it would just randomly fail saying that a field didn't exist, but re-running the same test again would make it pass, and I couldn't reproduce it locally. Updating all tests to run on xenial seems to have stopped the failures.

@liquidpele liquidpele merged commit c10bc61 into master May 1, 2019
@liquidpele liquidpele deleted the create_upgrade_tests branch May 1, 2019 23:29
@moseb moseb mentioned this pull request May 2, 2019
@auvipy auvipy added this to the 1.5.0 milestone May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants