Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extracting encryption from cdap-security into cdap-common #15786

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Extracting encryption from cdap-security into cdap-common #15786

wants to merge 1 commit into from

Conversation

masivesky
Copy link
Contributor

@masivesky masivesky commented Jan 2, 2025 •
edited
Loading

Extracting encryption containing Cipher implementations into cdap-common to be used across other modules without needing dependency on cdap-security.

Verified following scenarios:

  1. Pipelines are being deployed successfully
  2. Pipeline runs are completing successfully
  3. Connection to databases is being established
  4. Metrics are being published
  5. All service pods are healthy
  6. Verified that audit logs are being published
  7. Verified working of namespace service accounts

@masivesky masivesky self-assigned this Jan 2, 2025
@masivesky masivesky added the build Triggers github actions build label Jan 2, 2025
@masivesky masivesky force-pushed the encryption-cdap-common-correct branch from 00f60af to 935912a Compare January 9, 2025 10:36
@masivesky masivesky marked this pull request as ready for review January 9, 2025 10:41
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
48.8% Coverage on New Code (required ≥ 80%)
5.2% Duplication on New Code (required ≤ 3%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsankit-google itsankit-google Awaiting requested review from itsankit-google

At least 1 approving review is required to merge this pull request.

Assignees

@masivesky masivesky

Labels
build Triggers github actions build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@masivesky