Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💚 Simplified CI #266

Merged
merged 3 commits into from
Mar 14, 2025
Merged

💚 Simplified CI #266

merged 3 commits into from
Mar 14, 2025

Conversation

Drewniok
Copy link
Collaborator

Description

This PR simplifies the CI.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@Drewniok Drewniok added the continuous integration Anything related to the CI setup label Feb 20, 2025
@Drewniok Drewniok self-assigned this Feb 20, 2025
@github-actions GitHub Actions
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@Drewniok Drewniok requested a review from wlambooy February 20, 2025 12:38
@Drewniok Drewniok changed the title 💚 Simplified CI. 💚 Simplified CI Feb 20, 2025
wlambooy
wlambooy requested changes Mar 1, 2025
View reviewed changes
Copy link
Collaborator

@wlambooy wlambooy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that! Just some small things I noticed to ensure the CI to be optimal and consistent with fiction. After that it's good to go 👍

@Drewniok Drewniok requested a review from wlambooy March 12, 2025 15:08
wlambooy
wlambooy approved these changes Mar 14, 2025
View reviewed changes
Copy link
Collaborator

@wlambooy wlambooy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@Drewniok Drewniok merged commit ef4a1d9 into main Mar 14, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlambooy wlambooy wlambooy approved these changes

Assignees

@Drewniok Drewniok

Labels
continuous integration Anything related to the CI setup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Drewniok @wlambooy