Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Parameter to move inputs to top border after hexagonalization #692

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

simon1hofmann
Copy link
Collaborator

Description

Parameter to move inputs to top border after hexagonalization

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@simon1hofmann simon1hofmann self-assigned this Mar 13, 2025
@simon1hofmann simon1hofmann added the enhancement New feature or request label Mar 13, 2025
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 95.45455% with 9 lines in your changes missing coverage. Please review.

Project coverage is 98.34%. Comparing base (bbb9a09) to head (abab6cd).

Files with missing lines Patch % Lines
...on/algorithms/physical_design/hexagonalization.hpp 94.91% 9 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #692      +/-   ##
==========================================
- Coverage   98.36%   98.34%   -0.02%     
==========================================
  Files         254      254              
  Lines       41399    41495      +96     
  Branches     1878     1901      +23     
==========================================
+ Hits        40723    40810      +87     
- Misses        676      685       +9     
Files with missing lines Coverage Δ
include/fiction/algorithms/path_finding/a_star.hpp 100.00% <100.00%> (ø)
...st/algorithms/physical_design/hexagonalization.cpp 100.00% <100.00%> (ø)
...on/algorithms/physical_design/hexagonalization.hpp 94.59% <94.91%> (-5.41%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbb9a09...abab6cd. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants