Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to 0.5.0 and fix probe rtt #7

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

update to 0.5.0 and fix probe rtt #7

wants to merge 3 commits into from

Conversation

fcangialosi
Copy link
Member

No description provided.

akshayknarayan
akshayknarayan reviewed Mar 18, 2019
View reviewed changes
Cargo.toml
@@ -6,7 +6,8 @@ authors = ["Akshay Narayan <[email protected]>"]
[dependencies]
clap = "2.29"
fnv = "1"
portus = "^0.4.1"
portus = { path = "/home/frank/portus" }
portus_export = { path = "/home/frank/portus/portus_export" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/home/frank?

src/lib.rs

use fnv::FnvHashMap;
use std::collections::HashMap;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this a different commit?

src/lib.rs
(when (&& (== target_inflight_reached true)
(&& (> Micros Flow.rtt_sample_us) (> Micros 200000))
(report)
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about moving these datapath programs to separate files ("*.ccp"), and using https://doc.rust-lang.org/std/macro.include_str.html?

@akshayknarayan
Copy link
Member

Also, the datapath program currently doesn't compile:

⇒  sudo ./target/release/bbr --ipc=netlink
Mar 18 17:36:50.291 INFO configured BBR, probe_rtt_interval: Duration { secs: 10, nanos: 0 }, ipc: netlink
Mar 18 17:36:50.291 INFO starting CCP, ipc: netlink, algorithm: bbr
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Error("Datapath program \"probe_rtt\" failed to compile: Error(\"Equiv expected Num, got Ok(Bool(Some(false)))\")")', src/libcore/result.rs:997:5
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

@akshayknarayan
Copy link
Member

need to rebase the portus_export stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshayknarayan akshayknarayan akshayknarayan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fcangialosi @akshayknarayan