-
Notifications
You must be signed in to change notification settings - Fork 0
Preserving class structure and deserializing to a dictionary #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cmanallen
wants to merge
10
commits into
master
Choose a base branch
from
immutable
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
dac388f
Restructured tests
cmanallen e933481
Restructured model to return a seperate datatype
cmanallen aaca762
Simplified field interactions and removed Adapted prefix
cmanallen 7c565f8
Not deserializing null values
cmanallen ce98ea2
Added dump field
cmanallen 53c059a
Copying deserialized output
cmanallen 3e41c60
Added coverage for pass by value
cmanallen 1399e7a
Updated import paths
cmanallen 9731ba5
Upgraded to python 3.5
cmanallen 88e042e
Revert "Upgraded to python 3.5"
cmanallen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,4 @@ | ||
| nose==1.3.7 | ||
| wsgiref==0.1.2 | ||
| sphinx | ||
| sphinx-autobuild | ||
| sphinx-rtd-theme | ||
| -e git+https://github.com/caxiam/model-api.git#egg=Package | ||
| sphinx-rtd-theme |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| # -*- coding: utf-8 -*- | ||
| import errors | ||
| import fields | ||
| import models | ||
| from rest_orm import errors | ||
| from rest_orm import fields | ||
| from rest_orm import models |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@morgan This is the relevant part that was causing the issue. Using
copyprevents an accidental reference to the field class from being passed and updated.