Suggestions about @Transactional annotation usage #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, I found that there may be some minor improvements about annotations in your code. By adding @transactional at the class level, many important aspects such as transaction propagation can be handled automatically. It can wrap your service in a generated proxy that joins an active transaction or starts a new one and commits or rolls the transaction back after your methods got executed. Based on the advantages mentioned above, I recommend that you add the @transactional annotation at the class level. Hope my suggestions are useful!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I found that there might be some minor improvements in your code.
By adding @transactional at the class level, many important aspects such as transaction propagation can be handled automatically. It can wrap your service in a generated proxy that joins an active transaction or starts a new one and commits or rolls the transaction back after your methods got executed.
Based on the advantages mentioned above, I recommend that you add the @transactional annotation at the class level.
Hope my suggestions are useful!