Skip to content

HelpersTask659_Improve_dependency_checking_for_helpers #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 37 commits into
base: master
Choose a base branch
from
Open

HelpersTask659_Improve_dependency_checking_for_helpers #660

wants to merge 37 commits into from

Conversation

gpsaggese
Copy link
Contributor

gpsaggese added 4 commits May 4, 2025 18:40
@gpsaggese
Update
5369c2d 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@gpsaggese
Update
ff93cce 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@gpsaggese
Use llm_transform to use our style and convention
c09716a 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@gpsaggese
Lint
b1e322b 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@ehaabbasil ehaabbasil assigned ehaabbasil and unassigned ehaabbasil May 4, 2025
gpsaggese added 8 commits May 4, 2025 19:51
@gpsaggese
Lint
7f60e14 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@gpsaggese
Lint
adb7cec 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@gpsaggese
Lint
a9d108d 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@gpsaggese
Lint
718df8e 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@gpsaggese
Lint
ad39bd7 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@gpsaggese
Lint
895ebf9 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@gpsaggese
Lint
7a0bd46 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@gpsaggese
Add TODOs
e12fb11 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@gpsaggese gpsaggese mentioned this pull request May 5, 2025
Open
Ehaab Basil and others added 3 commits May 7, 2025 11:58
Add .gitignore
1e7c0ea 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@ehaabbasil
Updates: TODOs addressed
64eea9a 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@ehaabbasil
Update: handle case for show_deps
ce9f005 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@ehaabbasil ehaabbasil added the PR for reviewers The PR needs to be reviewed by RPs label May 10, 2025
ehaabbasil added 4 commits May 10, 2025 12:01
@ehaabbasil
Updates: lint fixes
acd3039 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@ehaabbasil
Update: fixed path mismatch in test_package_only_import
6239725 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@ehaabbasil
Update: test_dot_output
ea045b3 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@ehaabbasil
Updates
d2d72fc 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@ehaabbasil ehaabbasil added PR for reviewers The PR needs to be reviewed by RPs and removed PR for reviewers The PR needs to be reviewed by RPs labels May 11, 2025
@ehaabbasil ehaabbasil marked this pull request as ready for review May 11, 2025 22:17
ehaabbasil added 3 commits May 11, 2025 19:08
@ehaabbasil
Update: Typo
47746fb 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@ehaabbasil
Update: .gitignore
572fb22 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@ehaabbasil
Updates: styling fix and outcome
70652a3 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
ehaabbasil added 3 commits May 12, 2025 09:31
@ehaabbasil
Update: outcome test fix
1376ee8 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@ehaabbasil
Updates: lint fixes
ccd2df6 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@ehaabbasil
Updates: comment
009a71f 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@ehaabbasil ehaabbasil requested a review from sonniki May 13, 2025 15:58
@ehaabbasil
Copy link

ehaabbasil commented May 13, 2025 •
edited
Loading

invoke run_coverage_report import_check/test/test_dependency_graph.py

test_dot_output fails on invoke but passes on pytest

FAILED import_check/test/test_dependency_graph.py::TestDependencyGraph::test_dot_output - ModuleNotFoundError: No module named 'pydot'

run_coverage_report
========================= 1 failed, 9 passed in 25.57s =========================

pytest
========================= 10 passed in 0.95s=================================

sonniki
sonniki reviewed May 14, 2025
View reviewed changes
Copy link
Contributor

@sonniki sonniki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a PR with only the changes pertaining to the task? This one 1) has conflicts with master, 2) has files/changes in files that aren not related to the task.

Also let's make sure to adhere to our conventions for docstrings and comments.

@sonniki sonniki added PR for authors The PR needs changes and removed PR for reviewers The PR needs to be reviewed by RPs labels May 14, 2025
gpsaggese
gpsaggese commented May 15, 2025
View reviewed changes
Copy link
Contributor Author

@gpsaggese gpsaggese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cosmetic stuff. I'm going to read it top-to-bottom next

gpsaggese and others added 11 commits May 15, 2025 13:30
@gpsaggese
Update
c2a9765 
Pre-commit checks:
All checks passed ✅
@gpsaggese
Update
b1b3230 
Pre-commit checks:
All checks passed ✅
@ehaabbasil
Updates: TODOs
1c5cf8c 
Pre-commit checks:
All checks passed ✅
@ehaabbasil
Updates: show_deps.py invoke show_deps / generate_deps
7d45eee 
Pre-commit checks:
All checks passed ✅
@ehaabbasil
Update gitignore
1ed6808 
Pre-commit checks:
All checks passed ✅
@ehaabbasil
Update: conflict
4386534 
Pre-commit checks:
All checks passed ✅
@ehaabbasil
Update: requirements check
4e78b18 
Pre-commit checks:
All checks passed ✅
@ehaabbasil
Resolve set_path conflict in thin_client_utils.sh
e669114 
Pre-commit checks:
All checks passed ✅
@ehaabbasil
Resolve import conflict tasks.py
3eab857 
Pre-commit checks:
All checks passed ✅
@ehaabbasil
Resolve conflicts tasks.py
9d4043f 
Pre-commit checks:
All checks passed ✅
@ehaabbasil
Update:tasks.py
f89a51f 
Pre-commit checks:
All checks passed ✅
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonniki sonniki sonniki left review comments

Assignees

@ehaabbasil ehaabbasil

Labels
PR for authors The PR needs changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gpsaggese @ehaabbasil @sonniki