Skip to content

fix: Seal coffin and dig grave is not constructable. #3793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

Treah
Copy link
Contributor

@Treah Treah commented Dec 1, 2023

Purpose of change

Changed construction.json to remove flag that was probably from an earlier version of the game. The game checks to see if the furniture ground is diggable before allowing construction This will never succeed and the recipe is forever grayed out.

Describe the solution

Removed flag from recipe.

Describe alternatives you've considered

None

Testing

Tested on local build.

Additional context

Checklist

Removed flag that prevents this from ever being able to be built. After this the recipe is construct-able.
@github-actions github-actions bot added the JSON related to game datas in JSON format. label Dec 1, 2023
@Treah Treah changed the title FIX: Seal coffin and dig grave is not constructable. fix Seal coffin and dig grave is not constructable. Dec 1, 2023
@Treah Treah changed the title fix Seal coffin and dig grave is not constructable. fix: Seal coffin and dig grave is not constructable. Dec 1, 2023
@scarf005 scarf005 self-requested a review December 2, 2023 10:56
@scarf005 scarf005 self-assigned this Dec 2, 2023
@scarf005
Copy link
Member

scarf005 commented Dec 2, 2023

Tested on local build.

It'd be appreciated if the section described how to test it step-by-step.

Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grave.mp4
  1. built a coffin
  2. sealed a coffin
  3. buried a coffin

LGTM!

@scarf005 scarf005 added this pull request to the merge queue Dec 2, 2023
Merged via the queue into cataclysmbnteam:upload with commit 10a979a Dec 2, 2023
@Treah
Copy link
Contributor Author

Treah commented Dec 2, 2023

Tested on local build.

It'd be appreciated if the section described how to test it step-by-step.

Sorry next PR i do like this I will give you that step by step. This was a very simple change so I did not think it needed anything like that.

@Treah Treah deleted the patch-1 branch June 18, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants