fix(balance,port): evaporated milk quench #3789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scarf005
changed the title
scarf005
changed the title
scarf005
requested changes
Dec 1, 2023
There was a problem hiding this comment.
Could we add Co-authored-by in commit, as this PR originates from DDA?
this means rebasing commits and adding Co-authored-by in commit body. if you're unfamiliar with command-line git (and rebasing), please let me know.
scarf005
changed the title
|
I don't know much about quench but does less water actually lead to less quench in this case or is it a misconception? |
Co-authored-by: oosyrag <[email protected]>
|
At first glance, less water means less quench. |
scarf005
approved these changes
Dec 2, 2023
There was a problem hiding this comment.
I approve this change, rationale:
- evaporated milk having less water sounds natural.
- this 'nerf' only applies to a single item, and does not affect resource management around drinks since they are abdundant and waters are cheap.
it'd be great if the purpose of change section described the reason of this change directly, however.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
Saw this: Cataclysm-DDA/pull/69526
So :
Evaporated milk quench to 10.
Describe the solution
Change 25 to 10.
Additional context