Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content,mods/fuji_mpp): mainline a few more professions, add combat engineer #3783

Merged
merged 3 commits into from
Dec 2, 2023

Conversation

chaosvolt
Copy link
Member

Purpose of change

Planned followup to the profession updates I did.

Describe the solution

  1. Mainlined the automatic rifleman, grenadier, and designated marksman professions from Fuji's mod.
  2. Modernized and cleaned up the starting skills and items of said professions. Point costs set 1 higher than rifleman, descriptions rewritten to be less meme-y, starting skills updated to resemble that of rifleman's starting skillset, basic uniform and misc items consistent with the rifleman, hand grenades in the requisite pouch, automatic rifleman's vest holding mags for their sidearm, M249 assigned an ACOG scope instead of holo sight, marksman's M14 assigned a scope instead of ACOG, automatic rifleman nerfed to only carry 200 rounds of their primary weapon's ammo, etc.
  3. Added a combat engineer profession I wrote up. Geared towards having the basics of construction and some relevant entry tools, along with a smattering of utility skills all relevant to building and successfully placing bots (though for balance reasons not enough to autolearn much of that, since is a lot of skills).
  4. Removed the injections of mainlined professions from Fuji's mod, adding the new professions to heli crash and overrun in vanilla.
  5. Misc: Updated the military pilot profession to actually put their M17 magazines in the leg pouch they start with.

Describe alternatives you've considered

  1. Mainlining all the professions from the mod.
  2. Putting the combat engineer's C-4 in a grenade pouch?

Testing

  1. Checked affected files for syntax and lint errors.
  2. Loaded up Fuji's mod to ensure I didn't break anything.
  3. Looked at profession loadouts to check that things looked reasonably consistent.

Additional context

Screenshots:

Automatic rifleman:
auto

Grenadier:
gren

Designated marksman:
mark

Engineer:
engi

Checklist

@github-actions github-actions bot added JSON related to game datas in JSON format. mods PR changes related to mods. labels Nov 30, 2023
@scarf005 scarf005 self-requested a review December 2, 2023 10:56
@scarf005 scarf005 self-assigned this Dec 2, 2023
@scarf005 scarf005 changed the title feat(content): mainline a few more professions, add combat engineer feat(content,mods/fuji_mpp): mainline a few more professions, add combat engineer Dec 2, 2023
@scarf005 scarf005 added this pull request to the merge queue Dec 2, 2023
Merged via the queue into cataclysmbnteam:upload with commit 6372260 Dec 2, 2023
11 checks passed
@chaosvolt chaosvolt deleted the profession-mainlining branch December 2, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. mods PR changes related to mods.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants