Skip to content

Support Sourcelink and Deterministic Build #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Support Sourcelink and Deterministic Build #669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e20a3e0
Support Sourcelink and Deterministic Build
304NotModified Sep 27, 2023
806720d
Update CHANGELOG.md
304NotModified Sep 27, 2023
d3aa0bd
snupkg to AppVeyor
304NotModified Sep 27, 2023
ce8ff2b
Update Castle.Services.Logging.NLogIntegration.csproj
304NotModified Sep 27, 2023
d37a56d
Update Castle.Services.Logging.SerilogIntegration.csproj
304NotModified Sep 27, 2023
24e05e5
Update Castle.Services.Logging.log4netIntegration.csproj
304NotModified Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
Enhancements:
- Two new generic method overloads `proxyGenerator.CreateClassProxy<TClass>([options], constructorArguments, interceptors)` (@backstromjoel, #636)
- Allow specifying which attributes should always be copied to proxy class by adding attribute type to `AttributesToAlwaysReplicate`. Previously only non-inherited, with `Inherited=false`, attributes were copied. (@shoaibshakeel381, #633)
- Support for Sourcelink and Deterministic Build (@304NotModified, #669)

Bugfixes:
- `ArgumentException`: "Could not find method overriding method" with overridden class method having generic by-ref parameter (@stakx, #657)
Expand Down
2 changes: 2 additions & 0 deletions appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,3 +76,5 @@ for:
artifacts:
- path: build\*.nupkg
name: core
- path: build\*.snupkg
name: core
16 changes: 15 additions & 1 deletion src/Castle.Core/Castle.Core.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,22 @@
<SignAssembly>True</SignAssembly>
<PublicSign Condition="'$(OS)'=='Unix'">true</PublicSign>
<PackageTags>castle dynamicproxy dynamic proxy dynamicproxy2 dictionaryadapter emailsender</PackageTags>
<RepositoryUrl>https://github.com/castleproject/Core</RepositoryUrl>
<RepositoryType>git</RepositoryType>
</PropertyGroup>

<PropertyGroup Condition="'$(CI)' == 'True'">
<!--Deterministic Build and Source Link settings -->
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
<EmbedUntrackedSources>true</EmbedUntrackedSources>
<IncludeSymbols>true</IncludeSymbols>
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All"/>
</ItemGroup>

<ItemGroup>
<None Remove="DynamicProxy\DynProxy.snk" />
</ItemGroup>
Expand Down Expand Up @@ -52,4 +66,4 @@
<Compile Include="..\..\buildscripts\CommonAssemblyInfo.cs" />
</ItemGroup>

</Project>
</Project>
16 changes: 15 additions & 1 deletion src/Castle.Services.Logging.NLogIntegration/Castle.Services.Logging.NLogIntegration.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,22 @@
<SignAssembly>True</SignAssembly>
<PublicSign Condition="'$(OS)'=='Unix'">true</PublicSign>
<PackageTags>castle logging NLog</PackageTags>
<RepositoryUrl>https://github.com/castleproject/Core</RepositoryUrl>
<RepositoryType>git</RepositoryType>
</PropertyGroup>

<PropertyGroup Condition="'$(CI)' == 'True'">
<!--Deterministic Build and Source Link settings -->
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
<EmbedUntrackedSources>true</EmbedUntrackedSources>
<IncludeSymbols>true</IncludeSymbols>
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All"/>
</ItemGroup>

<ItemGroup>
<Folder Include="Properties\" />
</ItemGroup>
Expand All @@ -36,4 +50,4 @@
<Compile Include="..\..\buildscripts\CommonAssemblyInfo.cs" />
</ItemGroup>

</Project>
</Project>
16 changes: 15 additions & 1 deletion ...tle.Services.Logging.SerilogIntegration/Castle.Services.Logging.SerilogIntegration.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,22 @@
<SignAssembly>True</SignAssembly>
<PublicSign Condition="'$(OS)'=='Unix'">true</PublicSign>
<PackageTags>castle logging serilog</PackageTags>
<RepositoryUrl>https://github.com/castleproject/Core</RepositoryUrl>
<RepositoryType>git</RepositoryType>
</PropertyGroup>

<PropertyGroup Condition="'$(CI)' == 'True'">
<!--Deterministic Build and Source Link settings -->
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
<EmbedUntrackedSources>true</EmbedUntrackedSources>
<IncludeSymbols>true</IncludeSymbols>
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All"/>
</ItemGroup>

<ItemGroup>
<Folder Include="Properties\" />
</ItemGroup>
Expand All @@ -32,4 +46,4 @@
<ProjectReference Include="..\Castle.Core\Castle.Core.csproj" />
</ItemGroup>

</Project>
</Project>
14 changes: 14 additions & 0 deletions ...tle.Services.Logging.log4netIntegration/Castle.Services.Logging.log4netIntegration.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,22 @@
<SignAssembly>True</SignAssembly>
<PublicSign Condition="'$(OS)'=='Unix'">true</PublicSign>
<PackageTags>castle logging log4net</PackageTags>
<RepositoryUrl>https://github.com/castleproject/Core</RepositoryUrl>
<RepositoryType>git</RepositoryType>
</PropertyGroup>

<PropertyGroup Condition="'$(CI)' == 'True'">
<!--Deterministic Build and Source Link settings -->
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
<EmbedUntrackedSources>true</EmbedUntrackedSources>
<IncludeSymbols>true</IncludeSymbols>
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All"/>
</ItemGroup>

<ItemGroup>
<Folder Include="Properties\" />
</ItemGroup>
Expand Down