QueryArrayWidget does not work with the foo=bar,baz syntax #1685

[gabn88]

This is the failing test.

[gabn88]

What should I do to get this merged in?

[carltongibson]

I'm still not following the desire here. The QueryArrayWidget is for old PHP-style price[] query string parameters.

[carltongibson]

Why is this import here?

[carltongibson]

This isn't a query array example. 🤔

[gabn88]

The idea is that all input would work, not just QueryArrays. Also ?price=1,2. QueryArray only supports ?price=1,price=2.

[gabn88]

Thanks for the review! Will update the PR.

The reason for this PR is that:

1. The ModelMultipleChoiceFilter expects an ?a=x&a=y search filter
2. The __in expects an ?a=x,y search filter

This makes it hard for the frontend to know when to use which and also the frontend like to use ?a=x,y also for the ModelMultipleChoiceFilter.

With this fixes, you can in both cases use a QueryArrayWidget and all three search filters, for all types of filtering that uses multiple entries (whether __in or ModelMultipleChoiceFilter):

1. a=x&a=y
2. a=x,y
3. a[]=x,y

[gabn88]

@carltongibson I know you are very busy, but do you a minute to express your feelings about this MR? It would solve some frontend head-aches.
Now they have to do:

__in: objects ? [objects?.map(object => object.id).join(',')] : undefined,

whereas otherwise it would be:

__in: objects?.map(object => object.id),`

apart from code cleanliness it is hard for the frontend to find out when they have to use which filter type, it will simply be omitted if you choose the wrong type.