fix for issue #918 of using entire folder as context#1179
Open
ProhoDimka wants to merge 1 commit intocarlrobertoh:masterfrom
Open
fix for issue #918 of using entire folder as context#1179ProhoDimka wants to merge 1 commit intocarlrobertoh:masterfrom
ProhoDimka wants to merge 1 commit intocarlrobertoh:masterfrom
Conversation
…nd flattenFiles methods for recursively collecting files with __pycache__ exclusion, updated getReferencedFiles to support FolderTagDetails, and includeFiles to correctly count tokens in files from folders.
carlrobertoh
reviewed
Feb 5, 2026
| * Returns true if the directory should be excluded from context (e.g. __pycache__). | ||
| */ | ||
| private boolean isExcludedDir(VirtualFile vf) { | ||
| return vf.isDirectory() && "__pycache__".equals(vf.getName()); |
Owner
There was a problem hiding this comment.
Let's use a proper isExcluded and isFileIgnored functions for this:
private fun isExcludedDir(vf: VirtualFile): Boolean {
return ProjectFileIndex.getInstance(project).isExcluded(vf) ||
FileTypeManager.getInstance().isFileIgnored(vf)
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing an issue #918
Added folder tag handling: implemented isExcludedDir, expandFolder, and flattenFiles methods for recursively collecting files with pycache exclusion, updated getReferencedFiles to support FolderTagDetails, and includeFiles to correctly count tokens in files from folders.