fix(optimize-css): indexing should account for nested components #77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optimize CSS plugin uses a pre-computed index of Carbon components (exported from the barrel file) to determine what classes to prune.
However, most components compose other components. These sub-components (are their sub-components) must be accounted for.
An example would be a selectable
DataTable
:The checkboxes for
DataTable
are a bespoke, internal-facing component. The optimize plugin does not include the bespoke checkbox styles.The solution is to: