Pull marquee stepping out of Redux #1063
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -56 B (0%) Total Size: 450 kB
|
captbaritone
force-pushed
the
local-marquee
branch
from
bf89ec5 to
4ffca91
Compare
captbaritone
force-pushed
the
local-marquee
branch
from
4ffca91 to
e1f4a6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marquee stepping happens continuously at a relatively rapid frequency. Keeping this data in Redux means we need to run many selectors every time we step. By moving this state into React local state we can reduce the amount of work that is needed on each step.