Auto-Sync WebAssembly #87
Conversation
| std::move(OpDataTypes), AccessFlag}); | ||
| } | ||
|
|
||
| if (InsOps.size() > 15) { |
There was a problem hiding this comment.
Certain WebAssembly vector instructions can have 16 operands, like v128.const that takes 16 8-bit integers as the operand.
What was the original rationale for setting the maximum count of operands to 15?
There was a problem hiding this comment.
No idea.
You can increase it as you wish. Just save the constant in a macro named NUM_WASM_OPS, this is a naming convention required for functions in Mapping.h
Please make yourself familiar with the helper functions in Mapping.h, MathExtras.h and utils.h. So you don't implemented something twice.
Sorry, wrong repo. I thought this was the Capstone PR :D
There was a problem hiding this comment.
This is <capstone-repo>/Mapping.h::MAX_NO_INSN_MAP_OPS.
Can you please rename it here and add comment why it is set to this value.
2 participants
This PR will upgrade WebAssembly to the new auto-sync mechanism. This is work-in-progress as I learn the auto-sync mechanism and the internals of Capstone.
The Capstone PR is capstone-engine/capstone#2816