Skip to content

test: adapt to cds 9 #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

test: adapt to cds 9 #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
883b7b5
Update logging.test.js
hm23 May 28, 2025
71f7fa9
Update tracing-messaging-with-outbox.test.js
hm23 May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/logging.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ describe('logging', () => {
attributes: {
'log.type': 'LogRecord',
'exception.message': "Cannot read properties of undefined (reading 'exist')",
'exception.stacktrace': s => s.match(/^TypeError: .+(\n\s+at .+){6}$/),
'exception.stacktrace': s => s.match(/^TypeError: .+(\n\s+at .+){5}$/),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stacktrace got shorter...

'exception.type': 'TypeError',
foo: 'bar'
}
Expand Down
4 changes: 1 addition & 3 deletions test/tracing-messaging-with-outbox.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@ const env = {
process.env.cds_requires_messaging = JSON.stringify(env)

const CHECK = (log, expect) => {
// 2: no outbox -> consumer gets new root context
// REVISIT: for some reason, the emit done in the on succeeded callback gets a new root context when running in jest
expect(log.output.match(/\[telemetry\] - elapsed times:/g).length).to.equal(3) //> actually 2
expect(log.output.match(/\[telemetry\] - elapsed times:/g).length).to.equal(4)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log.output in cds 8:
image

log.outputin cds 9:
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should deactivate the queue for the existing tests and then add extra ones for it

Copy link
Contributor Author

@hm23 hm23 Jun 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I understand your comment, sorry. Tests for outbox: false are already in place in test/tracing-messaging-without-outbox.test.js, or?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, but that worked because the persistent outbox was off by default, i.e., the disabling was omitted. now, we need to explicitly set the in memory outbox: https://github.com/cap-js/telemetry/pull/338/files#diff-08b958738e72f5b16d4eb669fe005de06cf9dfc430ecda1494064d1dec87c93bR5

}

describe(`tracing messaging - ${CASE}`, () => {
Expand Down
Loading