Support attachments with custom primary key fields (non-ID keys) #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…params Rewrote the nonDraftUpload function to avoid assuming the key name is ID. It now uses req.params[1] to access the correct key-value pairs for the Attachments entity. This makes the non-draft upload logic fully compatible with entities using custom key names instead of hardcoded ID.
Replaced the usage of hardcoded regex parsing in readAttachment with CAP’s req.params array to dynamically extract key values.
…ms instead of regex
|
@schiwekM @RoshniNaveenaS do you have a timeline already when you will make this fix available in the released version? I am a bit confused why you now did delete the branch @schiwekM I had tested fix/support-generic-primary-key-attachments back then and it indeed had fixed the issue. |
|
Hi @franksgit, it should be released next week. Could you checkout #276? At least from the coding there was another place which was not yet fixed by this PR which most likely contributed to your original issue. BR, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support in the @cap-js/attachments plugin to work with custom key names (not just ID) for entities using the attachments composition. It enables both draft and non-draft flows to work correctly when the key field is named differently (e.g., bookId, customId, etc.).
Fixes #209