Improve error handling and logging in attachment scan flow #224
+63
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow UI5 to extract and display a more readable message, and you avoid raw JSON exposure.
Ensures one failed scan doesn’t block others and allows better error handling with per-scan logging.
… flagged attachments
…ntent of flagged attachments" This reverts commit 0b54aa7.
RoshniNaveenaS
requested review from
dheerasameerk,
maheshsooryambylu and
rishikunnath2747
lib/malwareScanner.js
Outdated
| DEBUG?.('[SCAN] Malware scanner responded') | ||
| } catch (err) { | ||
| log.error('[SCAN][ScannerError]', err) | ||
| req?.error?.(502, 'Malware scanning service is currently unavailable.') |
There was a problem hiding this comment.
For any error from malware scanner why are we saying Service Unavailable ?
There was a problem hiding this comment.
now passing the generic error
maheshsooryambylu
approved these changes
Aug 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces enhanced error handling, logging, and user feedback improvements in the attachment scanning flow.
Related GitHub Issue - #219