Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create local storage unit test #242

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions pkg/util/storage/storage_test.go

This file was deleted.

95 changes: 95 additions & 0 deletions testing/storage_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,95 @@
/*
Copyright 2021 The Caoyingjunz Authors.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package storage

import (
"context"
"reflect"
"testing"
"time"

v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime"

clientsetfake "github.com/caoyingjunz/csi-driver-localstorage/pkg/client/clientset/versioned/fake"
"github.com/caoyingjunz/csi-driver-localstorage/pkg/client/informers/externalversions"
"github.com/caoyingjunz/csi-driver-localstorage/pkg/util/storage"
"github.com/caoyingjunz/csi-driver-localstorage/testing/wrapper"
)

var (
ls = []runtime.Object{
wrapper.MakeLocalStorage().WithName("ls-node1").WithNode("node1").Obj(),
}
)

func TestCreateLocalStorage(t *testing.T) {
tests := []struct {
name string
nodeName string
expect []string
}{
{
name: "create-ls-node1",
nodeName: "node1",
expect: []string{"ls-node1"},
},
{
name: "create-ls-node2",
nodeName: "node2",
expect: []string{"ls-node1", "ls-node2"},
},
{
name: "re-create-ls-node2",
nodeName: "node2",
expect: []string{"ls-node1", "ls-node2"},
},
}

ctx := context.Background()

lsClient := clientsetfake.NewSimpleClientset(ls...)
informerFactory := externalversions.NewSharedInformerFactory(lsClient, 1*time.Second)
informerFactory.Start(ctx.Done())
informerFactory.WaitForCacheSync(ctx.Done())

for _, test := range tests {
if err := storage.CreateLocalStorage(lsClient, test.nodeName); err != nil {
t.Errorf("case name: %s, create localstorage failed, err: %v\n", test.name, err)
}

lsList, err := lsClient.StorageV1().LocalStorages().List(ctx, v1.ListOptions{})
if err != nil {
t.Errorf("case name: %s, list localstorage failed, err: %v\n", test.name, err)
}

if len(lsList.Items) != len(test.expect) {
t.Errorf("case name: %s, expected ls num is not equal get", test.name)
}

var lsSet []string
for _, ls := range lsList.Items {
lsSet = append(lsSet, ls.Name)
}

if !reflect.DeepEqual(lsSet, test.expect) {
t.Errorf("case name: %s, after create localstorage, got is not equal expect", test.name)
}

t.Logf("case name: %s tests succeed", test.name)
}
}
63 changes: 63 additions & 0 deletions testing/wrapper/wrapper.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
/*
Copyright 2021 The Caoyingjunz Authors.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package wrapper

import (
v1 "k8s.io/api/core/v1"

localstoragev1 "github.com/caoyingjunz/csi-driver-localstorage/pkg/apis/localstorage/v1"
)

type NodeWrapper struct{ v1.Node }

func MakeNode() *NodeWrapper {
return &NodeWrapper{v1.Node{}}
}

// 返回内部封装的 node
func (n *NodeWrapper) Obj() *v1.Node {
return &n.Node
}

// 为 node 设置 name
func (n *NodeWrapper) WithName(name string) *NodeWrapper {
n.SetName(name)
return n
}

type LocalStorageWrapper struct{ localstoragev1.LocalStorage }

func MakeLocalStorage() *LocalStorageWrapper {
return &LocalStorageWrapper{localstoragev1.LocalStorage{}}
}

// 返回内部封装的 LocalStorage
func (ls *LocalStorageWrapper) Obj() *localstoragev1.LocalStorage {
return &ls.LocalStorage
}

// 为 LocalStorage 设置 name
func (ls *LocalStorageWrapper) WithName(name string) *LocalStorageWrapper {
ls.SetName(name)
return ls
}

// 为 LocalStorage 设置 node
func (ls *LocalStorageWrapper) WithNode(node string) *LocalStorageWrapper {
ls.Spec.Node = node
return ls
}