Skip to content

test: more reliable e2e - #2253

Open
pawelstepien-da wants to merge 25 commits into
mainfrom
pawel/e2e-reliability
Open

test: more reliable e2e#2253
pawelstepien-da wants to merge 25 commits into
mainfrom
pawel/e2e-reliability

Conversation

@pawelstepien-da

@pawelstepien-da pawelstepien-da commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Improvements to Wallet Gateway E2E tests aimed at reducing flakiness and making debugging easier.

Notable changes to tests:
-Added more assertions after actions, to ensure that they already took effect before proceeding to avoid race conditions or to fail early.
-Merged popup and separate page WG utils into one util with isPopup param.
-Reduced pollings that would make failures make tests take long time waiting for positive outcome that would never come.
-Wrapped test/utils step with test.step, added descriptions to steps and expects for more readable logs.
image

Notable changes to app logic, that were inducing flakiness, mostly race conditions not/rarely observed in regular usage, because of human speed:
-mock-oauth2 - added random as icp claim, which makes each JWT unique. Before they could be the same, if 2 token were generated in same second for same user and network.
-WG select network screen - submitting is locked until both listNetworks and listIdps requests finish. Before it was possible to click login with only listNetworks finished, while listIdps was still pending which caused UI error.
-WG UI root level component user-app now delays rendering page component for URL, until session verification completes, rendering "Loading..." instead. Before it could cause problems like page executing connectCallback just to be redirected to /login a moment later, or interrupting the session check (i.e. because a page list rendered too fast and test clicked "Add" button, causing a redirtect) resulted getSessionId going to catch which return sessionId null, which resulted in call to attemptRemoveSession - flaky and hard to debug.

Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
…il it knows whether session is ok

Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
…db reset

Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
…e-reliability

Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
@pawelstepien-da pawelstepien-da linked an issue Aug 10, 2026 that may be closed by this pull request
@pawelstepien-da
pawelstepien-da marked this pull request as ready for review August 10, 2026 15:36
@pawelstepien-da
pawelstepien-da requested a review from a team as a code owner August 10, 2026 15:36
{ waitForClose: true }
)

// TODO check dapp event, once removing tx starts emitting one

@pawelstepien-da pawelstepien-da Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve E2E testing utils

1 participant