test: more reliable e2e - #2253
Open
pawelstepien-da wants to merge 25 commits into
Open
Conversation
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
…il it knows whether session is ok Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
…db reset Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
…e-reliability Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
pawelstepien-da
commented
Aug 10, 2026
| { waitForClose: true } | ||
| ) | ||
|
|
||
| // TODO check dapp event, once removing tx starts emitting one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements to Wallet Gateway E2E tests aimed at reducing flakiness and making debugging easier.
Notable changes to tests:

-Added more assertions after actions, to ensure that they already took effect before proceeding to avoid race conditions or to fail early.
-Merged popup and separate page WG utils into one util with
isPopupparam.-Reduced pollings that would make failures make tests take long time waiting for positive outcome that would never come.
-Wrapped test/utils step with test.step, added descriptions to steps and expects for more readable logs.
Notable changes to app logic, that were inducing flakiness, mostly race conditions not/rarely observed in regular usage, because of human speed:
-mock-oauth2 - added random as
icpclaim, which makes each JWT unique. Before they could be the same, if 2 token were generated in same second for same user and network.-WG select network screen - submitting is locked until both
listNetworksandlistIdpsrequests finish. Before it was possible to click login with onlylistNetworksfinished, whilelistIdpswas still pending which caused UI error.-WG UI root level component
user-appnow delays rendering page component for URL, until session verification completes, rendering "Loading..." instead. Before it could cause problems like page executingconnectCallbackjust to be redirected to /login a moment later, or interrupting the session check (i.e. because a page list rendered too fast and test clicked "Add" button, causing a redirtect) resultedgetSessionIdgoing tocatchwhich return sessionId null, which resulted in call toattemptRemoveSession- flaky and hard to debug.