Gate local snippet source refs - #1310
Draft
danielporterda wants to merge 1 commit into
Draft
Conversation
Signed-off-by: danielporterda <daniel.porter@digitalasset.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds the explicit policy gate for preview-only local snippet references.
Local refs are rejected in committed-page mode and accepted only when the caller opts into local preview. Immutable and pull-request refs are unaffected. This PR returns a span-anchored issue but intentionally does not add remediation text or a CLI gate yet.
Why
Whether local refs are allowed is runtime policy, distinct from parsing their URI syntax and from source safety.
Validation
python -m pytest tests/test_local_snippet_source_policy.py tests/test_local_snippet_source_parser.py(9 passed)python -m ruff check scripts/snippets/model.py scripts/snippets/validation.py tests/test_local_snippet_source_policy.pypython -m mypy scripts/snippets/model.py scripts/snippets/validation.pygit diff --check