-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: migrate actions runners off ubuntu 20.04 #2163
ci: migrate actions runners off ubuntu 20.04 #2163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for investigating this.
1099e66
to
84aa5f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to see we're moving to more recent runners, but the workaround for the firewall thing is misplaced IMO
84aa5f0
to
33b0493
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
GitHub actions will be deprecating the 20.04 image on 2025-04-01[1]. Let's move to ubuntu-24.04. [1] https://github.com/actions/runner-images/issues/ 11101
Running LXD and Docker on the same host has known connectivity issues. This caused CI failures when transitioning the GitHub action runner images from ubuntu-20.04 to ubuntu-24.04. The LXD documentation has a few recommended workarounds[1] and this one is the only one that worked well with GitHub CI. [1] https://documentation.ubuntu.com/lxd/en/latest/howto/network_bridge_firewalld/#prevent-connectivity-issues-with-lxd-and-docker
33b0493
to
7a2dace
Compare
During some testing today I got a notification that GitHub actions will be deprecating the 20.04 image on 2025-04-01[1] so let's migrate away. Unless we have any reason to use the oldest supported version, let's start using
ubuntu-latestubuntu-24.04
. It looks like we were on 22.04 but moved back to 20.04 because of setup issues[2], which I believe I was able to replicate and fix here.The problem: The GitHub Actions runner images have Docker pre-installed and connectivity issues with LXD and Docker both installed on a system is a known issue[3]. Though I don't know why the previously used
ubuntu-20.04
images didn't have this issue even though they also have Docker installed. I'll also note that I did try the "simpler" solution in [3] but for whatever reason I couldn't get that work.[1] actions/runner-images#11101
[2] #1852
[3] https://documentation.ubuntu.com/lxd/en/latest/howto/network_bridge_firewalld/#prevent-connectivity-issues-with-lxd-and-docker