pile: work around perf regression when moving to urwid from core24 #2161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogayot
force-pushed
the
storage-urwid-perf
branch
from
3af4842 to
6e7ce13
Compare
urwid added support in Pile() for widgets with fixed sizing. However, this caused big performance issues for us. Going up and down in the guided storage screen is > 30 times slower now. Maybe there is something smart to do ; but in the meantime, let's "revert" the upstream urwid change in our own Pile() implementation. LP: #2089681 Signed-off-by: Olivier Gayot <[email protected]>
ogayot
force-pushed
the
storage-urwid-perf
branch
from
6e7ce13 to
9aeacf6
Compare
mwhudson
approved these changes
Feb 17, 2025
dbungert
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
urwid added support in Pile() objects for widgets with fixed sizing. However, this caused big performance issues for us. Going up and down in the the guided storage screen is > 30 times slower now.
Maybe there is something smart to do ; but in the meantime, let's "revert" the upstream urwid change in our own Pile() implementation.
LP:#2089681
urwid/urwid#733