Noble merge 2025 01 28 #2152
Merged
Noble merge 2025 01 28 #2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ogayot
commented
Jan 28, 2025
ogayot
commented
- cherry-pick 938c0ed from install: remove previous uuid= and rp-partuuid= in the factory reset grub config #2123
- cherry-pick 850b871 from storage: always accept to resize a partition that is being wiped #2149
- LP:#2096799
- Bump curtin revision to include cherry-picks of:
- canonical/curtin@eb0728c from https://code.launchpad.net/~seb128/curtin/+git/curtin/+merge/478991
- canonical/curtin@7e487a9 from https://code.launchpad.net/~dbungert/curtin/+git/curtin/+merge/475870
…grub config We received a report that, after creating a USB reset media from the system and reinstalled, the system cannot boot into factory reset partition again. We found out that there are two uuid= entries in `etc/grub/grub.cfg` in the reinstalled factory reset partition. This is to remove the additional uuid= and rp-partuuid= entries if they are found in the kernel cmdline we are going to manipulate. (cherry picked from commit 938c0ed)
If we are wiping a partition, don't bother checking if the filesystem that was on it supports resizing. The filesystem is going to be erased anyway. The new filesystem (if any) will be created using mkfs.* so there is no need for resize support. LP: #2096799 Signed-off-by: Olivier Gayot <[email protected]> (cherry picked from commit 850b871)
Chris-Peterson444
approved these changes
Jan 28, 2025
dbungert
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.