Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvm-test: add option to add extra disks for install #1523

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

ogayot
Copy link
Member

@ogayot ogayot commented Jan 3, 2023

The patch introduces a new option --disk-count to create additional disks in kvm-test. It also makes the --disksize option usable multiple times so we can specify the size of each disk.

kvm-test.py --disk-count 2

... will result in two disks, each of the default size (12G)

kvm-test.py --disk-count 2 --disk-size 5G --disk-size 10G

... will result in a disk of size 5G and another disk of size 10G.

For now, this approach does not allow to selectively specify the size of each disk (i.e., you can't specify the size of disk 2 without specifying the size of disk 1).

Copy link
Collaborator

@dbungert dbungert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. I was able to do the raid1 isotracker test with this config.

Copy link
Contributor

@Chris-Peterson444 Chris-Peterson444 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ogayot requested a review from dbungert >2 years ago

A long time coming! 👀

This is great, thanks!

The patch introduces a new option --disk-count to create additional disks in
kvm-test. It also makes the --disksize option usable multiple times so we can
specify the size of each disk.

 $ kvm-test.py --disk-count 2

... will result in two disks, each of the default size (12G)

 $ kvm-test.py --disk-count 2 --disk-size 5G --disk-size 10G

... will result in a disk of size 5G and another disk of size 10G.

For now, this approach does not allow to selectively specify the size of each
disk (i.e., you can't specify the size of disk 2 without specifying the size of
disk 1).

Signed-off-by: Olivier Gayot <[email protected]>
@ogayot ogayot force-pushed the kvm-test-extra-disks branch from 021fa9b to b412c21 Compare February 14, 2025 20:32
@ogayot ogayot merged commit 932e785 into canonical:main Feb 17, 2025
10 checks passed
@ogayot ogayot deleted the kvm-test-extra-disks branch February 17, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants