Skip to content

Commit

Permalink
ci: update cla-check to has-signed-canonical-cla@v2
Browse files Browse the repository at this point in the history
The option for accepting existing contributors was removed
from the CLA checker in v2 with the following reasoning[1,2]:

	Remove the option for accepting existing contributors, as
	contributors can revoke their CLA agreement. The CLA must
	be checked with every commit.

For Subiquity's case, this seems to mostly have been used as a
workaround for Canonical employees signing commits with their Ubuntu
member emails addresses[3], which the v1 CLA checker had trouble with.
This doesn't look like it'll be an issue with v2 so we can safely proceed
with removing this.

[1] https://github.com/canonical/has-signed-canonical-cla/releases/tag/2.0.0
[2] canonical/has-signed-canonical-cla@82ea789
[3] 6b1700b
  • Loading branch information
Chris-Peterson444 committed Feb 18, 2025
1 parent e2038de commit 4ce839b
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/cla-check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,4 @@ jobs:
runs-on: ubuntu-20.04
steps:
- name: Check if CLA signed
uses: canonical/has-signed-canonical-cla@v1
with:
accept-existing-contributors: true
uses: canonical/has-signed-canonical-cla@v2

0 comments on commit 4ce839b

Please sign in to comment.