Conversation
be34961 to
1d99d4e
Compare
4005f81 to
517ae65
Compare
278398b to
4a6e7bb
Compare
3ec64c7 to
6b0abb8
Compare
6b0abb8 to
ba37289
Compare
There was a problem hiding this comment.
Pull request overview
This pull request updates the GitHub Actions test workflow to build a local spread binary from a pinned commit instead of relying on a potentially outdated system-provided version. The PR also adds explicit unit test execution and updates the Google Cloud credentials handling to use a file-based approach.
Changes:
- Added a dedicated step to run Go unit tests
- Introduced a step to build a specific version of the spread binary from source
- Modified the spread configuration to use file-based Google Cloud credentials instead of environment variables
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/test.yaml | Added unit test execution, local spread binary build from pinned commit, and updated credential handling to use key.json file |
| spread.yaml | Changed Google Cloud key configuration from environment variable to file-based approach |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
8cfdbf6 to
1de9c3a
Compare
Don't rely on GitHub runners providing a (potentially outdated) spread binary. Instead, check out a reference version and build a local binary to be used in the github CI test. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
1de9c3a to
1de5e41
Compare
| uname -a | ||
| trap 'rm -f /tmp/key.json' EXIT | ||
| (umask 177; echo "${{ secrets.SPREAD_GOOGLE_KEY }}" | base64 -d > /tmp/key.json) | ||
| /usr/bin/spread google: |
There was a problem hiding this comment.
This is curious.. we're moving from keeping the key in memory in an environment variable, to keeping it in the filesystem, but the only place we use it seems to be right next to where we write down. I'm happy to merge this regardless so you can test it, if you wish, but why aren't we just doing what we used to do, which is reading the variable from the environment itself?
Don't rely on GitHub runners providing a (potentially outdated)
spread binary. Instead, check out a reference version and build a
local binary to be used in the github CI test.