Sgmoore/kde neon qt6

[ScarlettGatelyMoore]

• [ x] Have you followed the guidelines for contributing?
• [x ] Have you signed the CLA?
• [x ] Have you successfully run tox run -m lint?
• [x ] Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

---

This is for a standalone kde-qt6 content pack support.

[ScarlettGatelyMoore]

@mr-cal @lengau @sergiusens If you could please take a look, Thanks

[bepri]

Thanks Scarlett!

[codecov]

Codecov Report

Attention: Patch coverage is 96.29630% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.73%. Comparing base (654871d) to head (8c85fde).
Report is 698 commits behind head on main.

Files with missing lines	Patch %	Lines
snapcraft/extensions/kde_neon_qt6.py	96.25%	3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (654871d) and HEAD (8c85fde). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (654871d)	HEAD (8c85fde)
	2	1

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5236      +/-   ##
==========================================
- Coverage   94.88%   89.73%   -5.16%     
==========================================
  Files         658      343     -315     
  Lines       55189    22717   -32472     
==========================================
- Hits        52364    20384   -31980     
+ Misses       2825     2333     -492     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ScarlettGatelyMoore]

I need help with ruff

ruff failed
Cause: TOML parse error at line 49, column 1
|
49 | lint.select = [
| ^^^^
unknown field lint, expected one of allowed-confusables, builtins, cache-dir, dummy-variable-rgx, exclude, extend, extend-exclude, extend-include, extend-ignore, extend-select, extend-fixable, extend-unfixable, external, fix, fix-only, fixable, output-format, force-exclude, ignore, ignore-init-module-imports, include, line-length, tab-size, logger-objects, required-version, respect-gitignore, select, show-source, show-fixes, src, namespace-packages, target-version, preview, task-tags, typing-modules, unfixable, flake8-annotations, flake8-bandit, flake8-bugbear, flake8-builtins, flake8-comprehensions, flake8-copyright, flake8-errmsg, flake8-quotes, flake8-self, flake8-tidy-imports, flake8-type-checking, flake8-gettext, flake8-implicit-str-concat, flake8-import-conventions, flake8-pytest-style, flake8-unused-arguments, isort, mccabe, pep8-naming, pycodestyle, pydocstyle, pyflakes, pylint, pyupgrade, format, per-file-ignores, extend-per-file-ignores

lint-ruff: exit 2 (0.00 seconds) /home/scarlett/ubuntu-core/snapcraft> ruff check --diff --respect-gitignore pid=51463
lint-ruff: FAIL ✖ in 0.36 seconds

It is outside my code and don't want to touch it.

pyproject.toml: 1
49: 1: lint.select = [
snapcraft_legacy/ruff.toml: 1
15: 1: lint.select = [

[ScarlettGatelyMoore]

Seems my local tests have different results. ruff wants me to remove the else on build environment exports and doing so breaks everything. Advice welcome.

[mr-cal]

@ScarlettGatelyMoore - what version of ruff do you have (ruff --version). It looks like the ruff snap was updated on the 7th, something may have broken or there is a mismatch between what you have locally and CI.

That formatting in snapcraft/extensions/kde_neon_qt6.py looks like it's trying to do:

if ...:
    return ...
else:
    return ...

to

if ...:
    return ...
return ...

That seems like the same logic to me, with or without the else.

[ScarlettGatelyMoore]

@ScarlettGatelyMoore - what version of ruff do you have (ruff --version). It looks like the ruff snap was updated on the 7th, something may have broken or there is a mismatch between what you have locally and CI.

That formatting in snapcraft/extensions/kde_neon_qt6.py looks like it's trying to do:

if ...:
    return ...
else:
    return ...

to

if ...:
    return ...
return ...

That seems like the same logic to me, with or without the else.

Not sure why it broke pytest when I did it then. I will give it another go. Thanks!

[ScarlettGatelyMoore]

Ok success, spread tests will not pass until the store approves kde-qt6-core24 name so I can upload... if any canonical folks know who to poke it would be super helpful. Thanks